Skip to content

Commit e59e921

Browse files
committed
fix(middleware-code-coverage): fix ping endpoint middleware version
This change ensures that the correct package.json is read to determine the middleware version. Previously the package.json relative to the `cwd` was used. Reading the version is only needed once per instance, not per request.
1 parent cc9aa1f commit e59e921

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

packages/middleware-code-coverage/lib/middleware.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ export default async function({log, middlewareUtil, options={}, resources}) {
4242
...generalConfig
4343
} = config;
4444

45+
const {version: middlewareVersion} = await readJsonFile(new URL("../package.json", import.meta.url));
46+
4547
// Instrumenter instance
4648
const instrumenter = createInstrumenter(instrumenterConfig);
4749
const instrument = promisify(instrumenter.instrument.bind(instrumenter));
@@ -84,8 +86,9 @@ export default async function({log, middlewareUtil, options={}, resources}) {
8486
* Endpoint to check for middleware existence
8587
*/
8688
router.get("/.ui5/coverage/ping", async (req, res) => {
87-
const {version} = await readJsonFile("./package.json");
88-
res.json({version});
89+
res.json({
90+
version: middlewareVersion
91+
});
8992
});
9093

9194
/**

0 commit comments

Comments
 (0)