Skip to content

Commit 3a0eca9

Browse files
authored
[builder][INTERNAL] Task generateLibraryPreload: Exclude component preload artefacts from library preload (SAP/ui5-builder#754)
1 parent 83e238a commit 3a0eca9

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

packages/builder/lib/tasks/bundlers/generateLibraryPreload.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ function getDefaultLibraryPreloadFilters(namespace, excludes) {
77
const filters = [
88
`${namespace}/`,
99
`${namespace}/**/manifest.json`,
10-
`!${namespace}/*-preload.js`, // exclude all bundles
10+
`!${namespace}/**/*-preload.js`, // exclude all bundles
1111
`!${namespace}/designtime/`,
1212
`!${namespace}/**/*.designtime.js`,
1313
`!${namespace}/**/*.support.js`

packages/builder/test/lib/tasks/bundlers/generateLibraryPreload.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ test.serial("generateLibraryPreload", async (t) => {
6565
filters: [
6666
"my/lib/",
6767
"my/lib/**/manifest.json",
68-
"!my/lib/*-preload.js",
68+
"!my/lib/**/*-preload.js",
6969
"!my/lib/designtime/",
7070
"!my/lib/**/*.designtime.js",
7171
"!my/lib/**/*.support.js",
@@ -354,7 +354,7 @@ test.serial("generateLibraryPreload for sap.ui.core (w/o ui5loader.js)", async (
354354
filters: [
355355
"sap/ui/core/",
356356
"sap/ui/core/**/manifest.json",
357-
"!sap/ui/core/*-preload.js",
357+
"!sap/ui/core/**/*-preload.js",
358358
"!sap/ui/core/designtime/",
359359
"!sap/ui/core/**/*.designtime.js",
360360
"!sap/ui/core/**/*.support.js",
@@ -636,7 +636,7 @@ test.serial("generateLibraryPreload for sap.ui.core (/w ui5loader.js)", async (t
636636
filters: [
637637
"sap/ui/core/",
638638
"sap/ui/core/**/manifest.json",
639-
"!sap/ui/core/*-preload.js",
639+
"!sap/ui/core/**/*-preload.js",
640640
"!sap/ui/core/designtime/",
641641
"!sap/ui/core/**/*.designtime.js",
642642
"!sap/ui/core/**/*.support.js",
@@ -970,7 +970,7 @@ test.serial("generateLibraryPreload for sap.ui.core with old specVersion defined
970970
filters: [
971971
"sap/ui/core/",
972972
"sap/ui/core/**/manifest.json",
973-
"!sap/ui/core/*-preload.js",
973+
"!sap/ui/core/**/*-preload.js",
974974
"!sap/ui/core/designtime/",
975975
"!sap/ui/core/**/*.designtime.js",
976976
"!sap/ui/core/**/*.support.js",
@@ -1126,7 +1126,7 @@ test.serial("generateLibraryPreload for sap.ui.core with own bundle configuratio
11261126
filters: [
11271127
"sap/ui/core/",
11281128
"sap/ui/core/**/manifest.json",
1129-
"!sap/ui/core/*-preload.js",
1129+
"!sap/ui/core/**/*-preload.js",
11301130
"!sap/ui/core/designtime/",
11311131
"!sap/ui/core/**/*.designtime.js",
11321132
"!sap/ui/core/**/*.support.js",
@@ -1293,7 +1293,7 @@ test.serial("generateLibraryPreload for sap.ui.core with own bundle configuratio
12931293
filters: [
12941294
"sap/ui/core/",
12951295
"sap/ui/core/**/manifest.json",
1296-
"!sap/ui/core/*-preload.js",
1296+
"!sap/ui/core/**/*-preload.js",
12971297
"!sap/ui/core/designtime/",
12981298
"!sap/ui/core/**/*.designtime.js",
12991299
"!sap/ui/core/**/*.support.js",
@@ -1482,7 +1482,7 @@ test.serial("generateLibraryPreload with excludes", async (t) => {
14821482
filters: [
14831483
"my/lib/",
14841484
"my/lib/**/manifest.json",
1485-
"!my/lib/*-preload.js",
1485+
"!my/lib/**/*-preload.js",
14861486
"!my/lib/designtime/",
14871487
"!my/lib/**/*.designtime.js",
14881488
"!my/lib/**/*.support.js",
@@ -1553,7 +1553,7 @@ test.serial("generateLibraryPreload with invalid excludes", async (t) => {
15531553
filters: [
15541554
"my/lib/",
15551555
"my/lib/**/manifest.json",
1556-
"!my/lib/*-preload.js",
1556+
"!my/lib/**/*-preload.js",
15571557
"!my/lib/designtime/",
15581558
"!my/lib/**/*.designtime.js",
15591559
"!my/lib/**/*.support.js"

0 commit comments

Comments
 (0)