Skip to content

Commit 438ea61

Browse files
committed
test: Update tests to reflect correctly elected conflicting version
1 parent 8dfe02f commit 438ea61

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

internal/shrinkwrap-extractor/test/lib/convertToShrinkwrap.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,16 @@ test("Version collisions: root packages get priority at top level", async (t) =>
117117

118118
const shrinkwrapJson = await convertPackageLockToShrinkwrap(cwd, "@ui5/cli");
119119

120-
// ansi-regex: root has v6.2.2, CLI workspace has v5.0.1
121-
// Root version should be at top level, workspace version nested
120+
// ansi-regex: root has v6.2.2, CLI workspace has v5.0.1, but not direct dependency to @ui5/cli
122121
const rootAnsiRegex = shrinkwrapJson.packages["node_modules/ansi-regex"];
123122
assert.equal(rootAnsiRegex?.version, "6.2.2", "Root ansi-regex at top level");
124123

125-
const cliAnsiRegex = shrinkwrapJson.packages["node_modules/@ui5/cli/node_modules/ansi-regex"];
126-
assert.equal(cliAnsiRegex?.version, "5.0.1", "Workspace ansi-regex nested under @ui5/cli");
124+
Object.keys(shrinkwrapJson.packages)
125+
.filter((pkg) => pkg.endsWith("node_modules/ansi-regex") && pkg !== "node_modules/ansi-regex")
126+
.forEach((pkgName) => {
127+
assert.equal(shrinkwrapJson.packages[pkgName]?.version,
128+
"5.0.1", `Workspace ansi-regex nested under @ui5/cli -> ${pkgName}`);
129+
});
127130

128131
// Verify root version satisfies dependents
129132
const stripAnsi = shrinkwrapJson.packages["node_modules/strip-ansi"];

0 commit comments

Comments
 (0)