Skip to content

Commit 935b292

Browse files
authored
ci: Fail-fast "npm ci" if deps require unsupported node version (#1172)
`+` ci(package.json): Update node version to current LTS (22) + latest (24) `+` ci(github-ci.yml): Update node version to current LTS (22) `+` ci(test.yml): Remove node20 for test matrix --- When upgrading a dependency to a newer version, it might require a different node version than before which could be unsupported by the repo. Unfortunately, this could be easily overseen. This PR adds the flag `--engine-strict` to the dependency installation step during the GH Actions job. Incase such a version requirement change, this flag will now fail-fast the job which should attract attention.
1 parent fdc9f69 commit 935b292

File tree

12 files changed

+23
-23
lines changed

12 files changed

+23
-23
lines changed

.github/workflows/github-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ jobs:
2222
- name: Setup Node.js
2323
uses: actions/setup-node@v6
2424
with:
25-
node-version: 20.11.0
25+
node-version: 22.20.0
2626

2727
- name: Install dependencies
28-
run: npm ci
28+
run: npm ci --engine-strict # --engine-strict is used to fail-fast if deps require node versions unsupported by the repo
2929

3030
- name: Perform ESLint check
3131
run: npm run lint

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
strategy:
1818
fail-fast: false # Do not stop other jobs if one fails
1919
matrix:
20-
version: [20, 22, 24]
20+
version: [22, 24]
2121
os: [ubuntu-24.04, windows-2025, macos-15]
2222
runs-on: ${{ matrix.os }}
2323
steps:

package-lock.json

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
],
2020
"type": "module",
2121
"engines": {
22-
"node": "^20.11.0 || >=22.0.0",
22+
"node": "^22.20.0 || >=24.0.0",
2323
"npm": ">= 8"
2424
},
2525
"scripts": {

packages/builder/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"./internal/jsdoc/template/publish": "./lib/processors/jsdoc/lib/ui5/template/publish.js"
3030
},
3131
"engines": {
32-
"node": "^20.11.0 || >=22.0.0",
32+
"node": "^22.20.0 || >=24.0.0",
3333
"npm": ">= 8"
3434
},
3535
"scripts": {

packages/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"./package.json": "./package.json"
2727
},
2828
"engines": {
29-
"node": "^20.11.0 || >=22.0.0",
29+
"node": "^22.20.0 || >=24.0.0",
3030
"npm": ">= 8"
3131
},
3232
"scripts": {

packages/documentation/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/documentation/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
],
1919
"type": "module",
2020
"engines": {
21-
"node": "^20.11.0 || >=22.0.0",
21+
"node": "^22.20.0 || >=24.0.0",
2222
"npm": ">= 8"
2323
},
2424
"scripts": {
@@ -39,4 +39,4 @@
3939
"vitepress": "^1.3.4",
4040
"vue": "^3.4.38"
4141
}
42-
}
42+
}

packages/fs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"./internal/ResourceTagCollection": "./lib/ResourceTagCollection.js"
3333
},
3434
"engines": {
35-
"node": "^20.11.0 || >=22.0.0",
35+
"node": "^22.20.0 || >=24.0.0",
3636
"npm": ">= 8"
3737
},
3838
"scripts": {

packages/logger/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"./internal/loggers/*": "./lib/loggers/*.js"
2626
},
2727
"engines": {
28-
"node": "^20.11.0 || >=22.0.0",
28+
"node": "^22.20.0 || >=24.0.0",
2929
"npm": ">= 8"
3030
},
3131
"scripts": {

0 commit comments

Comments
 (0)