Skip to content

Commit 987d74d

Browse files
authored
[builder][INTERNAL] use eslint-plugin-ava and cleanup test-suite (SAP/ui5-builder#783)
* [INTERNAL] use eslint-plugin-ava and cleanup test-suite * [INTERNAL] add ESLint ignore information * [INTERNAL] replace then handlers with correct async/await
1 parent 2b15d29 commit 987d74d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+897
-651
lines changed

packages/builder/.eslintrc.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ module.exports = {
33
"node": true,
44
"es2021": true
55
},
6-
"extends": ["eslint:recommended", "google"],
6+
"extends": ["eslint:recommended", "plugin:ava/recommended", "google"],
77
"plugins": [
8-
"jsdoc"
8+
"jsdoc",
9+
"ava"
910
],
1011
"rules": {
1112
"indent": [
@@ -64,7 +65,10 @@ module.exports = {
6465
"jsdoc/require-returns": 0,
6566
"jsdoc/require-returns-description": 0,
6667
"jsdoc/require-returns-type": 2,
67-
"jsdoc/valid-types": 0
68+
"jsdoc/valid-types": 0,
69+
// ava/assertion-arguments reports concatenated strings in a assertion message as an issue
70+
// See: https://github.com/avajs/eslint-plugin-ava/issues/332
71+
"ava/assertion-arguments": 0
6872
},
6973
"settings": {
7074
"jsdoc": {

packages/builder/package-lock.json

Lines changed: 271 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/builder/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@
136136
"eslint": "^8.7.0",
137137
"eslint-config-google": "^0.14.0",
138138
"eslint-plugin-jsdoc": "^37.6.3",
139+
"eslint-plugin-ava": "^13.2.0",
139140
"extract-zip": "^2.0.1",
140141
"mock-require": "^3.0.3",
141142
"nyc": "^15.1.0",

0 commit comments

Comments
 (0)