test(shrinkwrap-extractor): Add test for dependencies hoisted to the workspace root for packages other than the target

Author: RandomByte

internal/shrinkwrap-extractor/test/expected/package.c/npm-shrinkwrap.json

@@ -0,0 +1,68 @@
+{
+	"name": "@ui5/cli-monorepo",
+	"version": "0.0.1",
+	"lockfileVersion": 3,
+	"requires": true,
+	"packages": {
+		"": {
+			"name": "monorepo-root",
+			"version": "0.0.1",
+			"license": "Apache-2.0",
+			"workspaces": [
+				"packages/target",
+				"packages/module-a",
+				"packages/module-b"
+			],
+			"dependencies": {},
+			"devDependencies": {}
+		},
+		"node_modules/@ui5/target": {
+			"resolved": "packages/target",
+			"link": true
+		},
+		"node_modules/@ui5/module-a": {
+			"resolved": "packages/module-a",
+			"link": true
+		},
+		"node_modules/@ui5/module-b": {
+			"resolved": "packages/module-b",
+			"link": true
+		},
+		"packages/target": {
+			"name": "@ui5/target",
+			"version": "1.0.0",
+			"license": "Apache-2.0",
+			"dependencies": {
+				"@sapui5/some-thirdparty": "^1.0.0",
+				"@ui5/module-a": "^1.0.0",
+				"@ui5/module-b": "^1.0.0"
+			},
+			"devDependencies": {}
+		},
+		"packages/module-a": {
+			"name": "@ui5/module-a",
+			"version": "1.0.0",
+			"license": "Apache-2.0",
+			"dependencies": {
+				"@ui5/module-b": "^1.0.0",
+				"@sapui5/some-thirdparty": "^2.0.0"
+			},
+			"devDependencies": {}
+		},
+		"packages/module-b": {
+			"name": "@ui5/module-b",
+			"version": "1.0.0",
+			"license": "Apache-2.0",
+			"dependencies": {
+				"@sapui5/some-thirdparty": "^2.0.0"
+			},
+			"devDependencies": {}
+		},
+		"node_modules/@sapui5/some-thirdparty": {
+			"version": "2.0.0"
+		},
+		"node_modules/@ui5/target/node_modules/@sapui5/some-thirdparty": {
+			"version": "1.0.0"
+		}
+	}
+}

internal/shrinkwrap-extractor/test/fixture/project.c/package-lock.fixture.json

@@ -119,7 +119,7 @@ test("Workspace paths should be normalized to node_modules format", async (t) =>
 	console.log(`✓ All ${packagePaths.length - 1} package paths correctly normalized`);
 });
 
-test("Compare generated shrinkwrap with expected result", async (t) => {
+test("Compare generated shrinkwrap with expected result: package.a", async (t) => {
 	// Setup mock to prevent actual npm registry requests
 	const mockRestore = setupPacoteMock();
 	t.after(() => mockRestore());
@@ -172,8 +172,7 @@ test("Compare generated shrinkwrap with expected result", async (t) => {
 		"Generated shrinkwrap packages should match expected");
 });
 
-
-test("Compare generated shrinkwrap with expected result", async (t) => {
+test("Compare generated shrinkwrap with expected result: package.b", async (t) => {
 	// Setup mock to prevent actual npm registry requests
 	const mockRestore = setupPacoteMock();
 	t.after(() => mockRestore());
@@ -204,6 +203,37 @@ test("Compare generated shrinkwrap with expected result", async (t) => {
 		"Generated shrinkwrap packages should match expected");
 });
 
+test("Compare generated shrinkwrap with expected result: package.c", async (t) => {
+	// Setup mock to prevent actual npm registry requests
+	const mockRestore = setupPacoteMock();
+	t.after(() => mockRestore());
+
+	const __dirname = import.meta.dirname;
+	const generatedShrinkwrapPath = path.join(__dirname, "..", "tmp", "package.c", "npm-shrinkwrap.generated.json");
+	// Clean any existing generated file
+	await mkdir(path.dirname(generatedShrinkwrapPath), {recursive: true});
+	await unlink(generatedShrinkwrapPath).catch(() => {});
+
+	// Generate shrinkwrap from fixture
+	const cwd = path.join(__dirname, "..", "fixture", "project.c");
+	const symlinkPath = await setupFixtureSymlink(cwd);
+	t.after(async () => await unlink(symlinkPath).catch(() => {}));
+
+	const targetPackageName = "@ui5/target";
+
+	const generatedShrinkwrap = await convertPackageLockToShrinkwrap(cwd, targetPackageName);
+
+	// Load expected shrinkwrap
+	const expectedShrinkwrapPath = path.join(__dirname, "..", "expected", "package.c", "npm-shrinkwrap.json");
+	const expectedShrinkwrap = await readJson(expectedShrinkwrapPath);
+
+	// Write generated shrinkwrap to tmp dir for debugging purposes
+	await writeFile(generatedShrinkwrapPath, JSON.stringify(generatedShrinkwrap, null, "\t"), "utf-8");
+
+	assert.deepEqual(generatedShrinkwrap.packages, expectedShrinkwrap.packages,
+		"Generated shrinkwrap packages should match expected");
+});
+
 // Error handling tests
 test("Error handling - invalid target package name", async (t) => {
 	const __dirname = import.meta.dirname;