refactor(project): Restrict component type to specVersion >= 5

Author: RandomByte

packages/project/lib/validation/schema/specVersion/kind/project.json

@@ -4,6 +4,26 @@
 
 	"type": "object",
 	"required": ["specVersion", "type"],
+	"allOf": [
+		{
+			"if": {
+				"required": ["type"],
+				"properties": {
+					"type": {
+						"const": "component"
+					}
+				}
+			},
+			"then": {
+				"properties": {
+					"specVersion": {
+						"const": "5.0",
+						"errorMessage": "The 'component' type is only supported with specVersion '5.0' and higher."
+					}
+				}
+			}
+		}
+	],
 	"properties": {
 		"specVersion": { "enum": ["5.0", "4.0", "3.2", "3.1", "3.0", "2.6", "2.5", "2.4", "2.3", "2.2", "2.1", "2.0"] },
 		"kind": {

packages/project/test/fixtures/component.a/ui5-test-configPath.yaml

@@ -1,5 +1,5 @@
 ---
-specVersion: "3.1"
+specVersion: "5.0"
 type: component
 metadata:
   name: component.a

packages/project/test/fixtures/component.a/ui5-test-error.yaml

@@ -1,5 +1,5 @@
 ---
-specVersion: "3.1"
+specVersion: "5.0"
 type: component
 metadata:
   name: component.a

packages/project/test/fixtures/component.a/ui5.yaml

@@ -1,5 +1,5 @@
 ---
-specVersion: "3.1"
+specVersion: "5.0"
 type: component
 metadata:
   name: component.a

packages/project/test/lib/specifications/types/Component.js

@@ -17,7 +17,7 @@ test.beforeEach((t) => {
 		version: "1.0.0",
 		modulePath: componentAPath,
 		configuration: {
-			specVersion: "3.1",
+			specVersion: "5.0",
 			kind: "project",
 			type: "component",
 			metadata: {name: "component.a"}
@@ -29,7 +29,7 @@ test.beforeEach((t) => {
 		version: "1.0.0",
 		modulePath: componentHPath,
 		configuration: {
-			specVersion: "3.1",
+			specVersion: "5.0",
 			kind: "project",
 			type: "component",
 			metadata: {name: "component.h"},
@@ -405,7 +405,7 @@ test("_configureAndValidatePaths: Custom src directory", async (t) => {
 		version: "1.0.0",
 		modulePath: componentHPath,
 		configuration: {
-			specVersion: "3.1",
+			specVersion: "5.0",
 			kind: "project",
 			type: "component",
 			metadata: {name: "component.h"},

packages/project/test/lib/validation/schema/specVersion/kind/project.js

@@ -83,7 +83,7 @@ test("Type library (no kind)", async (t) => {
 
 test("Type component", async (t) => {
 	await assertValidation(t, {
-		"specVersion": "3.1",
+		"specVersion": "5.0",
 		"kind": "project",
 		"type": "component",
 		"metadata": {
@@ -94,14 +94,40 @@ test("Type component", async (t) => {
 
 test("Type component (no kind)", async (t) => {
 	await assertValidation(t, {
-		"specVersion": "3.1",
+		"specVersion": "5.0",
 		"type": "component",
 		"metadata": {
 			"name": "my-component"
 		}
 	});
 });
 
+test("Type component, legacy specVersion", async (t) => {
+	await assertValidation(t, {
+		"specVersion": "4.0",
+		"kind": "project",
+		"type": "component",
+		"metadata": {
+			"name": "my-component"
+		}
+	}, [{
+		dataPath: "/specVersion",
+		keyword: "errorMessage",
+		message: "The 'component' type is only supported with specVersion '5.0' and higher.",
+		params: {
+			errors: [{
+				dataPath: "/specVersion",
+				keyword: "const",
+				message: "should be equal to constant",
+				params: {
+					allowedValue: "5.0",
+				},
+				schemaPath: "#/allOf/0/then/properties/specVersion/const",
+			}],
+		}
+	}]);
+});
+
 test("Type theme-library", async (t) => {
 	await assertValidation(t, {
 		"specVersion": "2.0",