refactor(autofix): Validate that all required arguments are provided in jQuery fixes

Smoke tests showed cases where applications missed to provide required
arguments. This lead to autofix errors in cases where we `.trim()` those
arguments:
> Cannot read properties of undefined (reading 'trim')

Author: RandomByte

src/linter/ui5Types/fix/collections/jqueryFixes.ts

@@ -80,6 +80,12 @@ t.declareModule("jQuery", [
 		t.namespace("resources", [
 			t.namespace("isBundle", callExpressionGeneratorFix({ // https://github.com/UI5/linter/issues/657
 				moduleName: "sap/base/i18n/ResourceBundle",
+				validateArguments(ctx, _, arg1) {
+					if (!arg1) {
+						return false;
+					}
+					return true;
+				},
 				generator(_ctx, [moduleIdentifier], arg1) {
 					return `${arg1.trim()} instanceof ${moduleIdentifier}`;
 				},
@@ -205,12 +211,15 @@ t.declareModule("jQuery", [
 		*/
 		t.namespace("extend", callExpressionGeneratorFix({
 			moduleName: "sap/base/util/merge",
-			validateArguments(ctx, _, arg1) {
-				if (arg1.kind !== ts.SyntaxKind.TrueKeyword) {
+			validateArguments(ctx, _, arg1, arg2) {
+				if (arg1?.kind !== ts.SyntaxKind.TrueKeyword) {
 					// If the first argument is not "true" (indicating a deep merge),
 					// do not apply the fix
 					return false;
 				}
+				if (!arg2) {
+					return false;
+				}
 				return true;
 			},
 			generator(ctx, [moduleIdentifierName], _, arg2, arg3) {
@@ -653,6 +662,13 @@ t.declareModule("jQuery", [
 			},
 		})),
 		t.namespace("isEqualNode", callExpressionGeneratorFix({
+			validateArguments(ctx, _, arg1, arg2) {
+				if (!arg1 || !arg2) {
+					// If either argument is missing, do not apply the fix
+					return false;
+				}
+				return true;
+			},
 			generator: (ctx, _, arg1, arg2) => {
 				return `!!${arg1.trim()}?.isEqualNode(${arg2.trim()})`;
 			},
@@ -725,7 +741,11 @@ t.declareModule("jQuery", [
 			},
 		})),
 		t.namespace("delayedCall", callExpressionGeneratorFix<{isFnString: boolean}>({
-			validateArguments: (ctx, _, _timeout, _objCtx, fnName) => {
+			validateArguments: (ctx, _, timeout, objCtx, fnName) => {
+				if (!timeout || !objCtx || !fnName) {
+					// If the function name is not provided, do not apply the fix
+					return false;
+				}
 				ctx.isFnString = !!fnName && ts.isStringLiteralLike(fnName);
 				return true;
 			},
@@ -745,7 +765,11 @@ t.declareModule("jQuery", [
 		})),
 		t.namespace("intervalCall", callExpressionGeneratorFix<{isFnString: boolean}>({
 			globalName: "setInterval",
-			validateArguments: (ctx, _, _timeout, _objCtx, fnName) => {
+			validateArguments: (ctx, _, timeout, objCtx, fnName) => {
+				if (!timeout || !objCtx || !fnName) {
+					// If the function name is not provided, do not apply the fix
+					return false;
+				}
 				ctx.isFnString = !!fnName && ts.isStringLiteralLike(fnName);
 				return true;
 			},
@@ -768,6 +792,13 @@ t.declareModule("jQuery", [
 	]), // jQuery.sap
 	// jQuery
 	t.namespace("inArray", callExpressionGeneratorFix({
+		validateArguments(ctx, _, arg1, arg2) {
+			if (!arg1 || !arg2) {
+				// If either argument is missing, do not apply the fix
+				return false;
+			}
+			return true;
+		},
 		generator: (ctx, _, arg1, arg2) => {
 			return `(${arg2.trim()} ? Array.prototype.indexOf.call(${arg2.trim()}, ${arg1.trim()}) : -1)`;
 		},

test/fixtures/autofix/jQueryNativeReplacements.js

@@ -63,14 +63,15 @@ sap.ui.define(["sap/ui/thirdparty/jquery"], async function (jQuery) {
 			});
 		});
 	});
-
+	jQuery.sap.delayedCall(50, this); // Invalid: Missing third argument must not be migrated
 	jQuery.sap.clearDelayedCall(delayedCallId);
 	var intervalCallId = jQuery.sap.intervalCall(1000, myObject, "myFunction");
 	var intervalCallId2 = jQuery.sap.intervalCall(1000, myObject, myObject.myFunction, ["myParam1"]);
 	var intervalCallId3 = jQuery.sap.intervalCall(1000, window, Array.isArray, ["myParam1"]);
 	var intervalCallId4 = jQuery.sap.intervalCall(1000, this, function () {
 		var padRight = jQuery.sap.padRight("a", "0", 4); // Also migrate internal content
 	}, ["myParam1", "myParam2"]);
+	jQuery.sap.intervalCall(50, this); // Invalid: Missing third argument must not be migrated
 	jQuery.sap.clearIntervalCall(intervalCallId);
 
 	const document = globalThis.document;
@@ -79,6 +80,7 @@ sap.ui.define(["sap/ui/thirdparty/jquery"], async function (jQuery) {
 	var element3 = jQuery.sap.domById();
 	const divList = document.getElementsByTagName("div");
 	var isEqNode = jQuery.sap.isEqualNode(divList[0], divList[0]);
+	jQuery.sap.isEqualNode(); // Invalid: Missing arguments must not be migrated
 
 	var person = {firstname: "Peter", lastname: "Miller" };
 	var newObj = jQuery.sap.newObject(person);
@@ -89,5 +91,6 @@ sap.ui.define(["sap/ui/thirdparty/jquery"], async function (jQuery) {
 
 	var myData = ["a", "b", "c"];
 	var indexOfEntity = jQuery.inArray("b", myData);
+	jQuery.inArray(); // Invalid: Missing arguments must not be migrated
 	var isValueAnArray = jQuery.isArray(myData);
 });

test/fixtures/autofix/jQuerySap.js

@@ -15,6 +15,7 @@ sap.ui.define(["sap/base/strings/NormalizePolyfill"], async function (NormalizeP
 		// https://github.com/UI5/linter/issues/521
 		var myBundle = innerScopeResourceBundle.create({url : "i18n/messagebundle.properties"});
 		var isBundle = jQuery.sap.resources.isBundle(myBundle);
+		jQuery.sap.resources.isBundle(); // Invalid: Missing argument must not be migrated
 	});
 
 	// https://github.com/UI5/linter/issues/522
@@ -152,6 +153,7 @@ sap.ui.define(["sap/base/strings/NormalizePolyfill"], async function (NormalizeP
 	var clone7 = jQuery.sap.extend(undefined, [undefined]); // Do not migrate.
 	var clone8 = jQuery.sap.extend(var1, var2); // Do not migrate. We don't know the types of var1 and var2
 	var clone9 = jQuery.sap.extend(12, [undefined]); // Do not migrate. We don't know how to handle this
+	var clone9 = jQuery.sap.extend(true); // Invalid: Missing second argument must not be migrated
 	var timestampsnumber = jQuery.sap.now();
 	var props = jQuery.sap.properties({ url: sap.ui.require.toUrl(sap.ui.require.toUrl("testdata/test.properties")) });
 	var myUid = jQuery.sap.uid();