refactor: Only check for enums if value is string

Author: matz3

src/linter/ui5Types/SourceFileLinter.ts

@@ -717,27 +717,28 @@ export default class SourceFileLinter {
 
 				if (propertyType.isUnion()) {
 					const valueType = this.checker.getTypeAtLocation(prop.initializer);
-
-					for (const type of propertyType.types) {
-						// Find out whether the value is assignable to one of the types
-						if (!this.checker.isTypeAssignableTo(valueType, type)) {
-							continue;
-						}
-						// If the type is just a string literal (no enum value), we need to look for a matching
-						// enum value in the list of types to check for its deprecation
-						if (!(type.flags & ts.TypeFlags.EnumLiteral) && type.isStringLiteral()) {
-							const enumType = propertyType.types.find((t) => {
-								return t.symbol?.name === type.value;
-							});
-							if (!enumType) {
+					if (valueType?.isStringLiteral()) {
+						for (const type of propertyType.types) {
+							// Find out whether the value is assignable to one of the types
+							if (!this.checker.isTypeAssignableTo(valueType, type)) {
 								continue;
 							}
-							const deprecationInfo = this.getDeprecationInfo(enumType.symbol);
-							if (deprecationInfo) {
-								this.#reporter.addMessage(MESSAGE.DEPRECATED_PROPERTY, {
-									propertyName: type.value,
-									details: deprecationInfo.messageDetails,
-								}, prop);
+							// If the type is just a string literal (no enum value), we need to look for a matching
+							// enum value in the list of types to check for its deprecation
+							if (!(type.flags & ts.TypeFlags.EnumLiteral) && type.isStringLiteral()) {
+								const enumType = propertyType.types.find((t) => {
+									return t.symbol?.name === type.value;
+								});
+								if (!enumType) {
+									continue;
+								}
+								const deprecationInfo = this.getDeprecationInfo(enumType.symbol);
+								if (deprecationInfo) {
+									this.#reporter.addMessage(MESSAGE.DEPRECATED_PROPERTY, {
+										propertyName: type.value,
+										details: deprecationInfo.messageDetails,
+									}, prop);
+								}
 							}
 						}
 					}

test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedApi.js

@@ -1,8 +1,8 @@
 sap.ui.define([
 	"sap/m/Button", "sap/m/DateTimeInput", "sap/base/util/includes", "sap/ui/Device", "sap/ui/core/library", "sap/ui/generic/app/navigation/service/NavigationHandler",
 	"sap/ui/table/Table", "sap/ui/table/plugins/MultiSelectionPlugin", "sap/ui/core/Configuration", "sap/m/library",
-	"sap/m/Input", "sap/m/TileContent", "sap/ui/layout/form/SimpleForm"
-], function(Button, DateTimeInput, includes, Device, coreLib, NavigationHandler, Table, MultiSelectionPlugin, Configuration, mobileLib, Input, TileContent, SimpleForm) {
+	"sap/m/Input", "sap/m/TileContent", "sap/ui/layout/form/SimpleForm", "sap/m/ResponsivePopover"
+], function(Button, DateTimeInput, includes, Device, coreLib, NavigationHandler, Table, MultiSelectionPlugin, Configuration, mobileLib, Input, TileContent, SimpleForm, ResponsivePopover) {
 	"use strict";
 	var dateTimeInput = new DateTimeInput(); // Control is deprecated. A finding only appears for the module dependency, not for the usage.
 
@@ -91,8 +91,12 @@ sap.ui.define([
 		type: "Date" // InputType.Date is deprecated
 	});
 
-	// Negative test: ResponsiveGridLayout is not deprecated
 	const simpleForm2 = new SimpleForm({
-		layout: "ResponsiveGridLayout" // ResponsiveGridLayout is not deprecated
+		layout: "ResponsiveGridLayout" // Negative test: ResponsiveGridLayout is not deprecated
+	});
+
+	const responsivePopover = new ResponsivePopover({
+		// ui5lint-disable-next-line no-globals
+		placement: sap.m.PlacementType.Auto // Negative test: PlacementType.Auto is not deprecated
 	});
 });