[FIX] Resolve messageDetails links as soon as there are messageDetails (#73)

MessageDetails' links used to be resolved just before displaying them.
This might cause an issue if the raw messageDetails are used:
`format=json`, for example
Now all messageDetails' links are resolved as soon as they are added to
the data structre

Author: d3xter666

packages/ui5-linter/src/detectors/Reporter.ts

@@ -8,6 +8,7 @@ import {
 } from "@jridgewell/trace-mapping";
 
 import {LintMessageSeverity} from "./AbstractDetector.js";
+import {resolveLinks} from "../formatter/lib/resolveLinks.js";
 
 import type {LintResult, LintMessage, CoverageInfo} from "./AbstractDetector.js";
 import type {
@@ -60,7 +61,7 @@ export default class Reporter implements BaseReporter {
 		};
 
 		if (messageDetails) {
-			msg["messageDetails"] = messageDetails;
+			msg["messageDetails"] = resolveLinks(messageDetails);
 		}
 
 		this.#messages.push(msg);
@@ -79,7 +80,7 @@ export default class Reporter implements BaseReporter {
 		};
 
 		if (messageDetails) {
-			coverageInfo["messageDetails"] = messageDetails;
+			coverageInfo["messageDetails"] = resolveLinks(messageDetails);
 		}
 
 		this.#coverageInfo.push(coverageInfo);

packages/ui5-linter/src/formatter/text.ts

@@ -1,6 +1,5 @@
 import chalk from "chalk";
 import {LintMessageSeverity, LintResult, LintMessage} from "../detectors/AbstractDetector.js";
-import {resolveLinks} from "./lib/resolveLinks.js";
 
 function formatSeverity(severity: LintMessageSeverity) {
 	if (severity === LintMessageSeverity.Error) {
@@ -78,7 +77,7 @@ export class Text {
 					messages.forEach((msg) => {
 						const messageDetails = (showDetails && msg.messageDetails) ? 
 							(`\n      ${chalk.white.bold("Details:")}\n      ` +
-							`${chalk.italic(resolveLinks(msg.messageDetails).replaceAll("\n", "\n      "))}`) : 
+							`${chalk.italic(msg.messageDetails.replaceAll("\n", "\n      "))}`) : 
 							"";
 
 						this.#writeln(

packages/ui5-linter/test/lib/formatter/lib/resolveLinks.ts

@@ -0,0 +1,23 @@
+import anyTest, { TestFn } from "ava";
+import { resolveLinks } from "../../../../src/formatter/lib/resolveLinks.js";
+
+const test = anyTest as TestFn;
+
+test("Test links", (t) => {
+	const input = [
+		"(since 1.120) - Please use {@link sap.ui.core.message.MessageType } instead.",
+		"(since 1.119) - Please use {@link sap.ui.core.Lib.getResourceBundleFor Lib.getResourceBundleFor }instead.",
+		"(since 1.118) - See {@link module :sap/ui/core/Theming.attachApplied Theming.attachApplied }instead.",
+		"(since 1.56) - Use {@link module :sap/ui/VersionInfo.load} instead",
+	];
+	const expected = [
+		"(since 1.120) - Please use sap.ui.core.message.MessageType (https://ui5.sap.com/1.120/#/api/sap.ui.core.message.MessageType) instead.",
+		"(since 1.119) - Please use Lib.getResourceBundleFor  (https://ui5.sap.com/1.120/#/api/sap.ui.core.Lib)instead.",
+		"(since 1.118) - See Theming.attachApplied (https://ui5.sap.com/1.120/#/api/module:sap/ui/core/Theming%23methods/sap/ui/core/Theming.attachApplied)instead.",
+		"(since 1.56) - Use sap/ui/VersionInfo.load (https://ui5.sap.com/1.120/#/api/module:sap/ui/VersionInfo%23methods/sap/ui/VersionInfo.load) instead"
+	];
+	
+	input.forEach((text, index) => {
+		t.is(resolveLinks(text), expected[index], "Correct resolution of links");
+	});
+});