fix: Ensure valid syntax when adding parameters

Author: matz3

src/autofix/solutions/amdImports.ts

@@ -156,9 +156,15 @@ export function addDependencies(
 			newParametersValue += ")";
 		}
 
-		const insertAfterParameterDeclaration = parameters?.[insertAfterIndex];
+		const insertAfterParameterDeclaration = parameters[insertAfterIndex];
+
+		const existingParameterLeft = insertAfterIndex > -1 && parameters.length > 0;
+		const existingParameterRight = insertAfterIndex === -1 && parameters.length > 0;
+
+		let value = existingParameterLeft ? ", " + newParametersValue : newParametersValue;
+		value += existingParameterRight ? ", " : "";
+
 		const start = insertAfterParameterDeclaration?.getEnd() ?? parameterSyntax.syntaxList.getStart();
-		const value = parameters.length ? ", " + newParametersValue : newParametersValue;
 		changeSet.push({
 			action: ChangeAction.INSERT,
 			start,

test/fixtures/autofix/GlobalsExistingDefineWithExistingUnusedParamsMultiple.js

@@ -0,0 +1,5 @@
+sap.ui.define([], function(Input, Button, ComboBox) {
+	"use strict";
+
+	new sap.m.Button();
+});

test/fixtures/autofix/GlobalsExistingDefineWithExistingUnusedParamsSingle.js

@@ -0,0 +1,5 @@
+sap.ui.define([], function(Input) {
+	"use strict";
+
+	new sap.m.Button();
+});

test/fixtures/autofix/GlobalsExistingDefineWithExistingUnusedParamsSingleMatching.js

@@ -0,0 +1,5 @@
+sap.ui.define([], function(Button) {
+	"use strict";
+
+	new sap.m.Button();
+});

test/lib/autofix/snapshots/autofix.ts.md

@@ -580,6 +580,78 @@ Generated by [AVA](https://avajs.dev).
     });␊
     `
 
+## General: GlobalsExistingDefineWithExistingUnusedParamsMultiple.js
+
+> Snapshot 1
+
+    [
+      {
+        coverageInfo: [],
+        errorCount: 0,
+        fatalErrorCount: 0,
+        filePath: 'GlobalsExistingDefineWithExistingUnusedParamsMultiple.js',
+        messages: [],
+        warningCount: 0,
+      },
+    ]
+
+> AutofixResult: /GlobalsExistingDefineWithExistingUnusedParamsMultiple.js
+
+    `sap.ui.define(["sap/m/Button"], function(MButton, Input, Button, ComboBox) {␊
+    	"use strict";␊
+    ␊
+    	new MButton();␊
+    });␊
+    `
+
+## General: GlobalsExistingDefineWithExistingUnusedParamsSingle.js
+
+> Snapshot 1
+
+    [
+      {
+        coverageInfo: [],
+        errorCount: 0,
+        fatalErrorCount: 0,
+        filePath: 'GlobalsExistingDefineWithExistingUnusedParamsSingle.js',
+        messages: [],
+        warningCount: 0,
+      },
+    ]
+
+> AutofixResult: /GlobalsExistingDefineWithExistingUnusedParamsSingle.js
+
+    `sap.ui.define(["sap/m/Button"], function(Button, Input) {␊
+    	"use strict";␊
+    ␊
+    	new Button();␊
+    });␊
+    `
+
+## General: GlobalsExistingDefineWithExistingUnusedParamsSingleMatching.js
+
+> Snapshot 1
+
+    [
+      {
+        coverageInfo: [],
+        errorCount: 0,
+        fatalErrorCount: 0,
+        filePath: 'GlobalsExistingDefineWithExistingUnusedParamsSingleMatching.js',
+        messages: [],
+        warningCount: 0,
+      },
+    ]
+
+> AutofixResult: /GlobalsExistingDefineWithExistingUnusedParamsSingleMatching.js
+
+    `sap.ui.define(["sap/m/Button"], function(MButton, Button) {␊
+    	"use strict";␊
+    ␊
+    	new MButton();␊
+    });␊
+    `
+
 ## General: GlobalsExistingDefineWithTrailingCommas.js
 
 > Snapshot 1