test(rules/renderer): Add tests for rendererer method declarations

Author: RandomByte

test/fixtures/linter/rules/renderer/13Control.js

@@ -0,0 +1,8 @@
+sap.ui.define(["sap/ui/core/Control"], function (Control) {
+	var myControl = Control.extend("mycomp.myControl", {
+		metadata: {},
+		renderer: function(oRm, oControl) {
+		}
+	});
+	return myControl;
+});

test/fixtures/linter/rules/renderer/14Control.js

@@ -0,0 +1,8 @@
+sap.ui.define(["sap/ui/core/Control"], function (Control) {
+	var myControl = Control.extend("mycomp.myControl", {
+		metadata: {},
+		renderer(oRm, oControl) {
+		}
+	});
+	return myControl;
+});

test/fixtures/linter/rules/renderer/ControlRendererDeclaration_negative.js

@@ -19,24 +19,6 @@ sap.ui.define([
 		renderer: undefined
 	});
 
-	const NegativeExample4 = Control.extend("sap.ui.demo.linter.controls.NegativeExample4", {
-		metadata: {},
-		renderer: function(oRm, oControl) {
-		}
-	});
-
-	const NegativeExample5 = Control.extend("sap.ui.demo.linter.controls.NegativeExample5", {
-		metadata: {},
-		renderer: (oRm, oControl) => {
-		}
-	});
-
-	const NegativeExample6 = Control.extend("sap.ui.demo.linter.controls.NegativeExample6", {
-		metadata: {},
-		renderer(oRm, oControl) {
-		}
-	});
-
 	const NegativeExample7 = Button.extend("sap.ui.demo.linter.controls.NegativeExample7", {
 		metadata: {},
 		renderer: {

test/lib/linter/rules/snapshots/renderer.ts.md

@@ -63,6 +63,42 @@ Generated by [AVA](https://avajs.dev).
         ],
         warningCount: 0,
       },
+      {
+        coverageInfo: [],
+        errorCount: 1,
+        fatalErrorCount: 0,
+        filePath: '13Control.js',
+        messages: [
+          {
+            column: 3,
+            line: 4,
+            message: 'Use of deprecated renderer detected. Define explicitly the {apiVersion: 2} parameter in the renderer object',
+            messageDetails: 'Renderer Object (https://ui5.sap.com/#/topic/c9ab34570cc14ea5ab72a6d1a4a03e3f)',
+            ruleId: 'no-deprecated-api',
+            severity: 2,
+            ui5TypeInfo: undefined,
+          },
+        ],
+        warningCount: 0,
+      },
+      {
+        coverageInfo: [],
+        errorCount: 1,
+        fatalErrorCount: 0,
+        filePath: '14Control.js',
+        messages: [
+          {
+            column: 3,
+            line: 4,
+            message: 'Use of deprecated renderer detected. Define explicitly the {apiVersion: 2} parameter in the renderer object',
+            messageDetails: 'Renderer Object (https://ui5.sap.com/#/topic/c9ab34570cc14ea5ab72a6d1a4a03e3f)',
+            ruleId: 'no-deprecated-api',
+            severity: 2,
+            ui5TypeInfo: undefined,
+          },
+        ],
+        warningCount: 0,
+      },
       {
         coverageInfo: [
           {
@@ -473,7 +509,7 @@ Generated by [AVA](https://avajs.dev).
       },
       {
         coverageInfo: [],
-        errorCount: 2,
+        errorCount: 1,
         fatalErrorCount: 0,
         filePath: 'ControlRendererDeclaration_negative.js',
         messages: [
@@ -494,15 +530,6 @@ Generated by [AVA](https://avajs.dev).
               },
             },
           },
-          {
-            column: 13,
-            line: 30,
-            message: 'Use of deprecated renderer detected. Define explicitly the {apiVersion: 2} parameter in the renderer object',
-            messageDetails: 'Renderer Object (https://ui5.sap.com/#/topic/c9ab34570cc14ea5ab72a6d1a4a03e3f)',
-            ruleId: 'no-deprecated-api',
-            severity: 2,
-            ui5TypeInfo: undefined,
-          },
         ],
         warningCount: 0,
       },