[FIX] Unhandled CallExpression expression syntax: NewExpression

Author: matz3

packages/ui5-linter/src/detectors/typeChecker/FileLinter.ts

@@ -143,6 +143,14 @@ export default class FileLinter {
 			return;
 		}
 
+		if (ts.isNewExpression(exprNode)) {
+			// e.g. new Class()();
+			// This is usually unexpected and there are currently no known deprecations of functions
+			// returned by a class constructor.
+			// However, the OPA Matchers are a known exception where constructors do return a function.
+			return;
+		}
+
 		if (!ts.isPropertyAccessExpression(exprNode) &&
 			!ts.isElementAccessExpression(exprNode) &&
 				!ts.isIdentifier(exprNode)) {

packages/ui5-linter/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedApi_negative.js

@@ -1,8 +1,9 @@
 sap.ui.define([
 	"sap/m/upload/UploadSet",
 	"sap/ui/thirdparty/jquery",
-	"sap/m/library"
-], function(UploadSet, jQuery, mobileLib) {
+	"sap/m/library",
+	"sap/ui/test/matchers/Ancestor"
+], function(UploadSet, jQuery, mobileLib, Ancestor) {
 
 	var uploadSet = new UploadSet({
 		noDataText: "No data" // OK: Property 'noDataText' is only deprecated as of 1.121
@@ -13,4 +14,9 @@ sap.ui.define([
 	});
 
 	mobileLib.InputType.Text;
+
+	// Matchers are classes but return a function instead of an instance.
+	// This is a special case w.r.t. AST nodes, so it should be covered.
+	// There is no deprecated API usage in the following line.
+	new Ancestor("my-button")(uploadSet);
 });