Skip to content

Commit 21d632c

Browse files
committed
[FIX] sap.m.MultiInput: Select all (ctrl+a) now selects the input text instead of all tokens
Change-Id: I684a96bc4f118ab8bfbe680a90422b3f770d0690 SNOW: DINC0792822
1 parent e536e1d commit 21d632c

File tree

2 files changed

+1
-33
lines changed

2 files changed

+1
-33
lines changed

src/sap.m/src/sap/m/MultiInput.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -917,16 +917,11 @@ function(
917917
if (!this.getEnabled()) {
918918
return;
919919
}
920+
920921
if (oEvent.which === KeyCodes.TAB) {
921922
oTokenizer.selectAllTokens(false);
922923
}
923924

924-
if ((oEvent.ctrlKey || oEvent.metaKey) && oEvent.which === KeyCodes.A && oTokenizer.getTokens().length > 0) {
925-
oTokenizer.focus();
926-
oTokenizer.selectAllTokens(true);
927-
oEvent.preventDefault();
928-
}
929-
930925
// ctrl/meta + I -> Open suggestions
931926
if ((oEvent.ctrlKey || oEvent.metaKey) && oEvent.which === KeyCodes.I && oTokenizer.getTokens().length) {
932927
oTokenizer._togglePopup();

src/sap.m/test/sap/m/qunit/MultiInput.qunit.js

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,33 +1136,6 @@ sap.ui.define([
11361136
assert.equal(token3.getSelected(), true, "Token3 got selected using ctrl+a");
11371137
});
11381138

1139-
QUnit.test("keyboard - ctrl + A with text", function(assert) {
1140-
this.clock = sinon.useFakeTimers();
1141-
var token1 = new Token();
1142-
var token2 = new Token();
1143-
var token3 = new Token();
1144-
this.multiInput1.setTokens([token1, token2, token3]);
1145-
1146-
this.multiInput1.updateDomValue("123");
1147-
qutils.triggerEvent("input", this.multiInput1.getFocusDomRef());
1148-
1149-
this.multiInput1.focus();
1150-
this.multiInput1.selectText(0, this.multiInput1.getValue().length);
1151-
assert.equal(this.multiInput1._$input.getSelectedText(), "123", "only texts are selected");
1152-
1153-
qutils.triggerKeydown(this.multiInput1.getDomRef(), KeyCodes.A, false, false, true); // trigger Control key + A
1154-
assert.equal(token1.getSelected(), true, "Token1 is selected");
1155-
assert.equal(token2.getSelected(), true, "Token2 is selected");
1156-
assert.equal(token3.getSelected(), true, "Token3 is selected");
1157-
1158-
qutils.triggerEvent("tap", this.multiInput1.getDomRef());
1159-
this.clock.tick(1);
1160-
1161-
assert.equal(token1.getSelected(), false, "Token1 is unselected");
1162-
assert.equal(token2.getSelected(), false, "Token2 is unselected");
1163-
assert.equal(token3.getSelected(), false, "Token3 is unselected");
1164-
this.clock.restore();
1165-
});
11661139
QUnit.test("esc key", function(assert) {
11671140

11681141
this.multiInput1.setValue("123");

0 commit comments

Comments
 (0)