[INTERNAL] sap.ui.core.sample.odata.v4.SalesOrders: remove obsolete properties

The code which changed the UI property bCreateItemPending has been
removed with change 5655437 but not all usages of that flag have been
removed. Remove unsed properties (iTransientItems and
oSalesOrderLineItemCreated) from the controller.

PS1: done
PS2: review comments

Change-Id: I92abc8cf475186c4434be0d67bdb2d8f1724435c
JIRA: CPOUI5ODATAV4-3393
CI: 253

Author: SvBe

src/sap.ui.core/test/sap/ui/core/demokit/sample/odata/v4/SalesOrders/Component.js

@@ -91,7 +91,6 @@ sap.ui.define([
 					"sap.ui.core.sample.odata.v4.SalesOrders.Component");
 
 				this.oUiModel = new JSONModel({
-					bCreateItemPending : false,
 					filterProductID : "",
 					filterValue : "",
 					itemFilter : aItemFilter,

src/sap.ui.core/test/sap/ui/core/demokit/sample/odata/v4/SalesOrders/Main.controller.js

@@ -21,8 +21,6 @@ sap.ui.define([
 		sServiceNamespace = "com.sap.gateway.default.zui5_epm_sample.v0002.";
 
 	return Controller.extend("sap.ui.core.sample.odata.v4.SalesOrders.Main", {
-		iTransientItems : 0,
-
 		formatAddress : function (oAddress) {
 			return oAddress
 			? `${oAddress.Street} ${oAddress.Building}`
@@ -189,7 +187,7 @@ sap.ui.define([
 			oTable.getItems()[0].focus();
 
 			// Note: this promise fails only if the transient entity is delete or canceled
-			this.oSalesOrderLineItemCreated = oContext.created().then(function () {
+			oContext.created().then(function () {
 				var oItem = oTable.getSelectedItem();
 
 				MessageBox.success("Line item created: " + oContext.getProperty("ItemPosition"));

src/sap.ui.core/test/sap/ui/core/demokit/sample/odata/v4/SalesOrders/Main.view.xml

@@ -129,8 +129,7 @@
 						dataRequested : '.onDataEvents'
 					}
 				}"
-			mode="{= ${ui>/bCreateItemPending} ? 'None' : 'SingleSelectMaster' }"
-			selectionChange=".onSalesOrdersSelect">
+			mode="SingleSelectMaster" selectionChange=".onSalesOrdersSelect">
 			<dependents>
 				<plugins:DataStateIndicator/>
 			</dependents>
@@ -142,8 +141,7 @@
 							<ToolbarLayoutData shrinkable="false"/>
 						</layoutData>
 					</Title>
-					<Button enabled="{!${ui>/bCreateItemPending}"
-						icon="sap-icon://add" id="createSalesOrder" press=".onCreateSalesOrder"
+					<Button icon="sap-icon://add" id="createSalesOrder" press=".onCreateSalesOrder"
 						tooltip="Create sales order"/>
 					<Button
 						enabled="{= ${ui>/bSalesOrderSelected} }"
@@ -152,15 +150,13 @@
 						tooltip="Delete selected sales order"/>
 					<Button
 						enabled="{= ${ui>/bSalesOrderSelected}
-							&amp;&amp; !${ui>/bSelectedSalesOrderTransient}
-							&amp;&amp; !${ui>/bCreateItemPending} }"
+							&amp;&amp; !${ui>/bSelectedSalesOrderTransient} }"
 						icon="sap-icon://synchronize"
 						id="refreshSelectedSalesOrder" press=".onRefreshSelectedSalesOrder"
 						tooltip="Refresh selected sales order"/>
 					<Button
 						enabled="{= ${ui>/bSalesOrderSelected}
-							&amp;&amp; !${ui>/bSelectedSalesOrderTransient}
-							&amp;&amp; !${ui>/bCreateItemPending} }"
+							&amp;&amp; !${ui>/bSelectedSalesOrderTransient} }"
 						id="confirmSalesOrder"
 						icon="sap-icon://accept"
 						press=".onConfirmSalesOrder" tooltip="Confirm selected sales order"/>
@@ -172,8 +168,7 @@
 						tooltip="Reset changes for selected sales order"/>
 					<Button
 							enabled="{= ${ui>/bSalesOrderSelected}
-								&amp;&amp; !${ui>/bSelectedSalesOrderTransient}
-								&amp;&amp; !${ui>/bCreateItemPending} }"
+								&amp;&amp; !${ui>/bSelectedSalesOrderTransient} }"
 							id="openSimulateDiscountDialog"
 							icon="sap-icon://simulate"
 							press=".onOpenSimulateDiscountDialog"