Skip to content

Commit 1d6f8e8

Browse files
authored
ci: Fail-fast "npm ci" if deps require unsupported node version (#387)
`+` refactor: Write correct node version in caption --- When upgrading a dependency to a newer version, it might require a different node version than before which could be unsupported by the repo. Unfortunately, this could be easily overseen. This PR adds the flag --engine-strict to the dependency installation step during the GH Actions job. Incase such a version requirement change, this flag will now fail-fast the job which should attract attention.
1 parent 792272f commit 1d6f8e8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/github-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ jobs:
1717

1818
- uses: actions/checkout@v5
1919

20-
- name: Use Node.js LTS 20.11.0
20+
- name: Use Node.js LTS 20.19.5
2121
uses: actions/setup-node@v6
2222
with:
2323
node-version: 20.19.5
2424

2525
- name: Install dependencies
26-
run: npm ci
26+
run: npm ci --engine-strict # --engine-strict is used to fail-fast if deps require node versions unsupported by the repo
2727

2828
- name: Perform checks and tests
2929
run: npm test

0 commit comments

Comments
 (0)