Skip to content

Commit 589f7b1

Browse files
committed
Apply UI5 best practices
1 parent ea6c8d6 commit 589f7b1

File tree

5 files changed

+24
-8
lines changed

5 files changed

+24
-8
lines changed

webapp/i18n/i18n.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
TITLE=todos
1+
TITLE=Todos
22
INPUT_PLACEHOLDER=What needs to be done?
33
CLEAR_COMPLETED=Clear completed
44
ACTIVE_ITEMS=Active items

webapp/i18n/i18n_de.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
TITLE=Todos
1+
TITLE=Aufgabenliste
22
INPUT_PLACEHOLDER=Was muss getan werden?
33
CLEAR_COMPLETED=Erledigte Einträge entfernen
44
ACTIVE_ITEMS=Aktive Einträge

webapp/i18n/i18n_en.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
TITLE=todos
1+
TITLE=Todos
22
INPUT_PLACEHOLDER=What needs to be done?
33
CLEAR_COMPLETED=Clear completed
44
ACTIVE_ITEMS=Active items

webapp/manifest.json

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,19 @@
22
"_version": "2.0.0",
33
"sap.app": {
44
"id": "sap.ui.demo.todo",
5-
"type": "application"
5+
"type": "application",
6+
"title": "{{TITLE}}",
7+
"applicationVersion": {
8+
"version": "0.5.0"
9+
}
10+
},
11+
"sap.ui": {
12+
"technology": "UI5",
13+
"deviceTypes": {
14+
"desktop": true,
15+
"tablet": true,
16+
"phone": true
17+
}
618
},
719
"sap.ui5": {
820
"dependencies": {
@@ -13,6 +25,10 @@
1325
"sap.f": {}
1426
}
1527
},
28+
"contentDensities": {
29+
"compact": true,
30+
"cozy": true
31+
},
1632
"rootView": {
1733
"viewName": "sap.ui.demo.todo.view.App",
1834
"type": "XML",

webapp/view/App.view.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
</infoToolbar>
4545
<CustomListItem>
4646
<HBox>
47-
<CheckBox selected="{completed}" />
47+
<CheckBox selected="{completed}" />
4848
<VBox justifyContent="Center">
4949
<Text text="{title}"/>
5050
</VBox>
@@ -63,9 +63,9 @@
6363
<OverflowToolbar id="toolbar-footer" visible="{= !!${view>/isMobile} }">
6464
<SegmentedButton selectedKey="all" selectionChange=".onFilter" class="sapMSegmentedButtonNoAutoWidth">
6565
<items>
66-
<SegmentedButtonItem text="All" key="all"/>
67-
<SegmentedButtonItem text="Active" key="active"/>
68-
<SegmentedButtonItem text="Completed" key="completed"/>
66+
<SegmentedButtonItem text="{i18n>LABEL_ALL}" key="all"/>
67+
<SegmentedButtonItem text="{i18n>LABEL_ACTIVE}" key="active"/>
68+
<SegmentedButtonItem text="{i18n>LABEL_COMPLETED}" key="completed"/>
6969
</items>
7070
</SegmentedButton>
7171
<ToolbarSpacer />

0 commit comments

Comments
 (0)