Skip to content

Commit 1a5343e

Browse files
authored
test: fix flaky tests (#7698)
1 parent 6219e49 commit 1a5343e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

docs/knowledge-base/FAQ.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ Further information about theming can be found in our and the UI5 Web Components
8484

8585
Each component developed by the UI5 Web Components team ([`ui5-webcomponents`](https://github.com/SAP/ui5-webcomponents)) that is wrapped by the UI5 Web Components for React ([`ui5-webcomponents-react`](https://github.com/SAP/ui5-webcomponents-react)) wrapper includes the following note in its component description:
8686

87-
**Note**: This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/)
87+
> **Note**: This is a UI5 Web Component! [Repository](https://github.com/SAP/ui5-webcomponents) | [Documentation](https://sap.github.io/ui5-webcomponents/)
8888
8989
If a component does not have this note, it is a React-only component provided exclusively by `ui5-webcomponents-react`.
9090

@@ -96,9 +96,9 @@ Additionally, Storybook supports filtering by tags, allowing you to filter by di
9696

9797
- <Badge type="custom" />: There are no global design or UX specifications for this component, or it deviates from them partially or fully. More details can be found in the component’s description.
9898
- <Badge type="experimental" />: The component or pattern is in an experimental state, meaning changes to its public API may occur without a major version update (`v3.0.0`).
99-
- <Badge type="deprecated" />: The component is deprecated and will be removed in the next major version update (`v3.0.0`). More details can be found the component's description.
99+
- <Badge type="deprecated" />: The component is deprecated and will be removed in the next major version update (`v3.0.0`). More details can be found in the component's description.
100100

101-
## Why Isn't Scoping working?
101+
## Why Isn't Scoping Working?
102102

103103
Starting from UI5 Web Components (for React) 2.0.0, the order of imports with regard to scoping and components matters.
104104
Setting the scoping suffix must be done before importing any components, as they use the suffix at the top-level of the module - meaning when a component is imported, the suffix has to be known.

packages/main/src/components/MessageView/MessageView.cy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ describe('MessageView', () => {
179179
// remaining props were already tested
180180
cy.findByText('SubtitleText').should('be.visible');
181181
cy.findByText('1337').should('be.visible');
182-
cy.get('[name="slim-arrow-right"]').should('be.visible').click();
182+
cy.get('[name="slim-arrow-right"]').should('be.visible').realClick();
183183
cy.findByText('SubtitleText').should('not.exist');
184184
cy.findByText('1337').should('not.exist');
185185
});

packages/main/src/components/ObjectPage/ObjectPage.cy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ describe('ObjectPage', () => {
431431
cy.findByTestId('footer').should('be.visible');
432432

433433
// Select Employment tab
434-
cy.get('[ui5-tabcontainer]').findUi5TabByText('Goals').click();
434+
cy.get('[ui5-tabcontainer]').findUi5TabByText('Goals').focus();
435435
cy.get('[ui5-tabcontainer]').realPress('ArrowRight');
436436
cy.get('[ui5-tabcontainer]').realPress('ArrowRight');
437437
cy.get('[ui5-tabcontainer]').realPress('ArrowRight');

0 commit comments

Comments
 (0)