Skip to content

Commit 1cfc884

Browse files
committed
fix(ObjectPage): update section spacing to latest specs
1 parent 99bb975 commit 1cfc884

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

packages/main/src/components/ObjectPageSection/ObjectPageSection.module.css

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@
44
&:first-of-type {
55
margin-block-start: 1px;
66
}
7+
margin-block-end: 1rem;
78
}
89

910
.section [data-component-name='ObjectPageSubSection']:not(:first-child) {
10-
padding-block-start: 0.5rem;
11+
padding-block-start: 1rem;
1112
}
1213

1314
.section:focus {
@@ -28,8 +29,8 @@
2829
}
2930

3031
.title {
31-
height: var(--_ui5wcr_ObjectPage_SectionTitleHeight);
32-
line-height: var(--_ui5wcr_ObjectPage_SectionTitleLineHeight);
32+
height: 2.25rem;
33+
line-height: 2.25rem;
3334
color: var(--sapGroup_TitleTextColor);
3435
font-size: var(--sapFontHeader4Size);
3536
display: inline-block;
@@ -62,7 +63,7 @@
6263
}
6364

6465
.sectionContentInner {
65-
padding-block: 0.5rem;
66+
padding-block-start: 1rem;
6667
font-family: var(--sapFontFamily);
6768
height: 100%;
6869
box-sizing: border-box;

packages/main/src/components/ObjectPageSubSection/ObjectPageSubSection.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
.subSectionContent {
2828
background-color: var(--_ui5wcr_ObjectPage_SubSectionBackgroundColor);
2929
border-radius: var(--_ui5wcr_ObjectPage_SubSectionBorderRadius);
30-
padding-block: 1rem;
30+
padding-block: 0.5rem;
3131
}
3232

3333
.spacer {

packages/main/src/themes/base.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
--_ui5wcr_ActionSheet_MobileHeaderBoxShadow: none;
2121
--_ui5wcr_ActionSheet_MobileHeaderTextColor: var(--sapContent_ContrastTextColor);
2222
--_ui5wcr_ObjectPage_SectionTitleFontFamily: var(--sapFontFamily);
23+
/*ToDo: no used anymore - remove in next major version */
2324
--_ui5wcr_ObjectPage_SectionTitleLineHeight: 2.25rem;
2425
--_ui5wcr_ObjectPage_SubSectionBorderRadius: 0;
2526
--_ui5wcr_Splitter_BarBorderHighContrastFix: var(--sapContent_FocusWidth) solid var(--sapContent_FocusColor);

packages/main/src/themes/sap_horizon.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
--_ui5wcr_ActionSheet_MobileHeaderBoxShadow: var(--sapContent_Shadow2);
1414
--_ui5wcr_ActionSheet_MobileHeaderTextColor: var(--sapPageHeader_TextColor);
1515
--_ui5wcr_ObjectPage_SectionTitleFontFamily: var(--sapFontBoldFamily);
16-
--_ui5wcr_ObjectPage_SectionTitleLineHeight: 4rem;
16+
--_ui5wcr_ObjectPage_SectionTitleLineHeight: 2.25rem;
1717
--_ui5wcr_ObjectPage_SubSectionBorderRadius: var(--sapElement_BorderCornerRadius);
1818
--_ui5wcr_ActionSheet_MobileHeaderBackground: var(--sapPageHeader_Background);
1919
--_ui5wcr_ActionSheet_MobileHeaderBorderRadius: var(--sapPopover_BorderCornerRadius);

packages/main/src/themes/sap_horizon_dark.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
--_ui5wcr_ActionSheet_MobileHeaderBoxShadow: var(--sapContent_Shadow2);
1414
--_ui5wcr_ActionSheet_MobileHeaderTextColor: var(--sapPageHeader_TextColor);
1515
--_ui5wcr_ObjectPage_SectionTitleFontFamily: var(--sapFontBoldFamily);
16-
--_ui5wcr_ObjectPage_SectionTitleLineHeight: 4rem;
16+
--_ui5wcr_ObjectPage_SectionTitleLineHeight: 2.25rem;
1717
--_ui5wcr_ObjectPage_SubSectionBorderRadius: var(--sapElement_BorderCornerRadius);
1818
--_ui5wcr_ActionSheet_MobileHeaderBackground: var(--sapPageHeader_Background);
1919
--_ui5wcr_ActionSheet_MobileHeaderBorderRadius: var(--sapPopover_BorderCornerRadius);

0 commit comments

Comments
 (0)