fix(AnalyticalTable): safeguard extension, header, title height calc

Author: Lukas742

packages/main/src/components/AnalyticalTable/index.tsx

@@ -90,7 +90,12 @@ import type {
   DivWithCustomScrollProp,
   TableInstance,
 } from './types/index.js';
-import { getRowHeight, getSubRowsByString, tagNamesWhichShouldNotSelectARow } from './util/index.js';
+import {
+  getObservedCombinedHeight,
+  getRowHeight,
+  getSubRowsByString,
+  tagNamesWhichShouldNotSelectARow,
+} from './util/index.js';
 import { VerticalResizer } from './VerticalResizer.js';
 
 // When a sorted column is removed from the visible columns array (e.g. when "popped-in"), it doesn't clean up the sorted columns leading to an undefined `sortType`.
@@ -391,10 +396,7 @@ const AnalyticalTable = forwardRef<AnalyticalTableDomRef, AnalyticalTablePropTyp
   const extensionRef = useRef(null);
   const headerRef = useRef(null);
 
-  const extensionsHeight =
-    (titleBarRef.current?.offsetHeight ?? 0) +
-    (extensionRef.current?.offsetHeight ?? 0) +
-    (headerRef.current?.offsetHeight ?? 0);
+  const extensionsHeight = getObservedCombinedHeight(0, titleBarRef, extensionRef, headerRef);
 
   const internalRowHeight = getRowHeight(rowHeight, tableRef);
   const internalHeaderRowHeight = headerRowHeight ?? internalRowHeight;

packages/main/src/components/AnalyticalTable/util/index.ts

@@ -176,3 +176,19 @@ export function getLeafHeaders(header) {
   recurseHeader(header);
   return leafHeaders;
 }
+
+export const getObservedCombinedHeight = (prevHeight: number, ...refs: RefObject<HTMLElement>[]): number => {
+  let height = 0;
+
+  for (const ref of refs) {
+    const el = ref.current;
+    if (!el) {
+      continue;
+    }
+    const elementHeight = el.offsetHeight;
+    height += elementHeight;
+  }
+
+  // Math.abs is required, because of layout thrashing (rounding errors)
+  return Math.abs(prevHeight - height) > 1 ? height : prevHeight;
+};