internal type imports

Keep internal type imports from base pkg root, refactor root main pkg internal type imports to deep base pkg imports

Author: Lukas742

packages/cli/src/scripts/codemod/transforms/export-maps/main.cts

@@ -10,7 +10,7 @@ const compatPackageName = '@ui5/webcomponents-react-compat';
 
 const packageNames = [mainPackageName, basePackageName, chartsPackageName, aiPackageName, compatPackageName];
 
-const ignoredImportedNames = new Set([
+const internalTypes = new Set([
   'ReducedReactNode',
   'ReducedReactNodeWithBoolean',
   'UI5WCSlotsNode',
@@ -85,7 +85,6 @@ try {
   console.warn(`⚠️ Could not read utils index at ${utilsIndexPath}.`, e);
 }
 
-// Mapping functions
 function resolveBaseExport(importedName: string): string | undefined {
   const directMap: Record<string, string> = {
     Device: `${basePackageName}/Device`,
@@ -146,7 +145,7 @@ export default function transform(file: FileInfo, api: API): string | undefined
   }
 
   let isDirty = false;
-
+  let shouldKeepOldImport = false;
   packageNames.forEach((pkg) => {
     root.find(j.ImportDeclaration, { source: { value: pkg } }).forEach((importPath) => {
       const specifiers = importPath.node.specifiers || [];
@@ -157,8 +156,28 @@ export default function transform(file: FileInfo, api: API): string | undefined
         }
 
         const importedName = spec.imported.name as string;
-
-        if (ignoredImportedNames.has(importedName)) {
+        shouldKeepOldImport = false;
+        if (internalTypes.has(importedName)) {
+          if (pkg === mainPackageName) {
+            const newImport = j.importDeclaration(
+              [
+                j.importSpecifier(
+                  j.identifier(importedName),
+                  j.identifier(spec.local && typeof spec.local.name === 'string' ? spec.local.name : importedName),
+                ),
+              ],
+              j.literal(`${basePackageName}/dist/types/index.js`),
+            );
+            if ('importKind' in spec && spec.importKind === 'type') {
+              newImport.importKind = 'type';
+            }
+            j(importPath).insertBefore(newImport);
+            isDirty = true;
+          } else {
+            // todo: clarify if this should be included as well
+            // If from base package, keep import as is for now
+            shouldKeepOldImport = true;
+          }
           return;
         }
 
@@ -202,7 +221,10 @@ export default function transform(file: FileInfo, api: API): string | undefined
         j(importPath).insertBefore(newImport);
         isDirty = true;
       });
-      j(importPath).remove();
+
+      if (!shouldKeepOldImport) {
+        j(importPath).remove();
+      }
     });
   });