Skip to content

Commit a31aa61

Browse files
committed
op: selection event
1 parent c589cb6 commit a31aa61

File tree

1 file changed

+2
-19
lines changed

1 file changed

+2
-19
lines changed

packages/main/src/components/ObjectPage/useHandleTabSelect.ts

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { debounce } from '@ui5/webcomponents-react-base';
22
import { enrichEventWithDetails } from '@ui5/webcomponents-react-base';
33
import type { Dispatch, JSXElementConstructor, MutableRefObject, ReactElement, RefObject, SetStateAction } from 'react';
4-
import { isValidElement, useEffect, useState } from 'react';
4+
import { isValidElement } from 'react';
55
import { ObjectPageMode } from '../../enums/ObjectPageMode.js';
66
import type { TabContainerPropTypes } from '../../webComponents/TabContainer/index.js';
77
import type { ObjectPageSectionPropTypes } from '../ObjectPageSection/index.js';
@@ -44,16 +44,6 @@ export const useHandleTabSelect = ({
4444
setTabSelectId,
4545
setWasUserSectionChange,
4646
}: UseHandleTabSelectProps) => {
47-
const [onSectionSelectedArgs, setOnSectionSelectedArgs] = useState<
48-
| false
49-
| [
50-
Parameters<TabContainerPropTypes['onTabSelect']>[0],
51-
undefined | string,
52-
string,
53-
ReactElement<ObjectPageSectionPropTypes>,
54-
]
55-
>(false);
56-
5747
const handleOnSubSectionSelected = (e) => {
5848
isProgrammaticallyScrolled.current = true;
5949
const sectionId = e.detail.sectionId;
@@ -105,20 +95,13 @@ export const useHandleTabSelect = ({
10595
const section = childrenArray.find((el) => {
10696
return el.props.id == sectionId;
10797
});
108-
setOnSectionSelectedArgs([event, section?.props?.id, index, section]);
98+
handleOnSectionSelected(event, section?.props?.id, index, section);
10999
}
110100

111101
if (mode === ObjectPageMode.IconTabBar) {
112102
setWasUserSectionChange(true);
113103
}
114104
};
115-
// effect required - if event is called in `handleTabItemSelect` it's invoked twice in StrictMode
116-
useEffect(() => {
117-
if (onSectionSelectedArgs) {
118-
handleOnSectionSelected(...onSectionSelectedArgs);
119-
setOnSectionSelectedArgs(false);
120-
}
121-
}, [onSectionSelectedArgs]);
122105

123106
return handleTabItemSelect;
124107
};

0 commit comments

Comments
 (0)