Skip to content

Commit a8a688d

Browse files
authored
docs(ObjectPage): always allow opening tabbar overflow popover (#7377)
If the popover is opened inside an iframe, the container’s dimensions change, and if a vertical scrollbar then appears, the popover will automatically close. Closes #7000
1 parent b13e0c2 commit a8a688d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/main/src/components/ObjectPage/ObjectPage.stories.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const meta = {
5858
selectedSectionId: 'goals',
5959
imageShapeCircle: true,
6060
image: SampleImage,
61-
style: { height: '700px' },
61+
style: { height: '700px', maxHeight: '90vh' },
6262
footerArea: (
6363
<Bar
6464
design={BarDesign.FloatingFooter}
@@ -134,8 +134,8 @@ type Story = StoryObj<typeof meta>;
134134
export const Default: Story = {
135135
render(args) {
136136
return (
137-
// `onBeforeNavigate` has to be called like this, otherwise it's invoked two times for some reason.
138-
<ObjectPage {...args} onBeforeNavigate={args.onBeforeNavigate}>
137+
// `onBeforeNavigate` & `onToggleHeaderArea` have to be added like this, otherwise Storybook invokes them incorrectly sometimes
138+
<ObjectPage {...args} onBeforeNavigate={args.onBeforeNavigate} onToggleHeaderArea={args.onToggleHeaderArea}>
139139
<ObjectPageSection titleText="Goals" id="goals" aria-label="Goals">
140140
<Form layout="S1 M2 L3 XL3" labelSpan="S12 M12 L12 XL12">
141141
<FormItem labelContent={<Label showColon>Evangelize the UI framework across the company</Label>}>

0 commit comments

Comments
 (0)