Skip to content

Commit b6b6bcb

Browse files
committed
fix legend click tests
1 parent 0b22f1a commit b6b6bcb

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

packages/charts/src/components/ComposedChart/ComposedChart.cy.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,7 @@ describe('ComposedChart', () => {
6969
}),
7070
);
7171

72-
//todo: onLegendClick is never fired, check why
73-
cy.contains('Users').click();
72+
cy.get('[class="recharts-legend-wrapper"]').findByText('Users').realClick();
7473
cy.get('@onLegendClick').should(
7574
'have.been.calledWith',
7675
Cypress.sinon.match({

packages/charts/src/components/DonutChart/DonutChart.cy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe('DonutChart', () => {
4343
}),
4444
);
4545

46-
cy.contains('January').click();
46+
cy.get('[class="recharts-legend-wrapper"]').findByText('January').realClick();
4747
cy.get('@onLegendClick').should(
4848
'have.been.calledWith',
4949
Cypress.sinon.match({

packages/charts/src/components/PieChart/PieChart.cy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ describe('PieChart', () => {
4444
}),
4545
);
4646

47-
cy.contains('January').click();
47+
cy.get('[class="recharts-legend-wrapper"]').findByText('January').realClick();
4848
cy.get('@onLegendClick').should(
4949
'have.been.calledWith',
5050
Cypress.sinon.match({

packages/charts/src/components/RadarChart/RadarChart.cy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ describe('RadarChart', () => {
5252
cy.get('[name="January"]').eq(0).click({ force: true });
5353
cy.get('@onClick').should('have.been.calledTwice');
5454

55-
cy.contains('Users').click();
55+
cy.get('[class="recharts-legend-wrapper"]').findByText('Users').realClick();
5656
cy.get('@onLegendClick').should(
5757
'have.been.calledWith',
5858
Cypress.sinon.match({

packages/charts/src/components/ScatterChart/ScatterChart.cy.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ describe('ScatterChart', () => {
4040
/>,
4141
);
4242

43-
cy.get('[name="Users"]').eq(0).click();
43+
//todo: datapoint click is broken
44+
cy.get('[name="APJ"]').eq(0).realClick();
4445
cy.get('@onClick')
4546
.should('have.been.calledOnce')
4647
.and(
@@ -52,12 +53,12 @@ describe('ScatterChart', () => {
5253
}),
5354
);
5455

55-
cy.contains('Users').click();
56+
cy.get('[class="recharts-legend-wrapper"]').findByText('APJ').realClick();
5657
cy.get('@onLegendClick').should(
5758
'have.been.calledWith',
5859
Cypress.sinon.match({
5960
detail: Cypress.sinon.match({
60-
value: 'Users',
61+
value: 'APJ',
6162
}),
6263
}),
6364
);

0 commit comments

Comments
 (0)