Skip to content

Commit c63ecc5

Browse files
committed
sync scroll after data update
1 parent 6fe2506 commit c63ecc5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/main/src/components/AnalyticalTable/hooks/useSyncScroll.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@ import { useEffect, useRef, useState } from 'react';
44
export function useSyncScroll(
55
refContent: MutableRefObject<HTMLElement>,
66
refScrollbar: MutableRefObject<HTMLElement>,
7+
isScrollable: boolean,
78
disabled = false,
89
) {
910
const isProgrammatic = useRef(false);
1011
const [isMounted, setIsMounted] = useState(false);
1112

1213
useEffect(() => {
13-
if (disabled) {
14+
if (disabled || !isScrollable) {
1415
return;
1516
}
1617

@@ -46,5 +47,5 @@ export function useSyncScroll(
4647
content.removeEventListener('scroll', onScrollContent);
4748
scrollbar.removeEventListener('scroll', onScrollScrollbar);
4849
};
49-
}, [isMounted, refContent, refScrollbar, disabled]);
50+
}, [isMounted, refContent, refScrollbar, disabled, isScrollable]);
5051
}

packages/main/src/components/AnalyticalTable/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ const AnalyticalTable = forwardRef<AnalyticalTableDomRef, AnalyticalTablePropTyp
661661
}
662662
}, [tableState.columnResizing, retainColumnWidth, tableState.tableColResized]);
663663

664-
useSyncScroll(parentRef, verticalScrollBarRef, isFirefox);
664+
useSyncScroll(parentRef, verticalScrollBarRef, tableState.isScrollable, isFirefox);
665665

666666
useEffect(() => {
667667
columnVirtualizer.measure();

0 commit comments

Comments
 (0)