Skip to content

Commit d12306f

Browse files
committed
cleanup, naming
1 parent 9d90836 commit d12306f

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

packages/main/src/components/ObjectPage/index.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
109109
const sections = mode === ObjectPageMode.IconTabBar ? currentTabModeSection : children;
110110
const scrollEndHandler = useOnScrollEnd({ objectPageRef, setTabSelectId });
111111
// only required for IconTabBar mode
112-
const [userSectionChange, setUserSectionChange] = useState(false);
112+
const [wasUserSectionChange, setWasUserSectionChange] = useState(false);
113113

114114
useEffect(() => {
115115
const currentSection =
@@ -605,7 +605,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
605605
scrollTimeout,
606606
setSelectedSubSectionId,
607607
setTabSelectId,
608-
setUserSectionChange,
608+
setWasUserSectionChange,
609609
});
610610
const objectPageStyles: CSSProperties = {
611611
...style,
@@ -765,15 +765,14 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
765765
className={classNames.content}
766766
ref={(node) => {
767767
if (node) {
768-
if (mode === ObjectPageMode.IconTabBar && userSectionChange) {
769-
console.log('focus');
768+
if (mode === ObjectPageMode.IconTabBar && wasUserSectionChange) {
770769
node.querySelector('[data-component-name="ObjectPageSection"]')?.focus({
771770
preventScroll: true,
772771
});
773772
}
774773
objectPageContentRef.current = node;
775774
}
776-
setUserSectionChange(false);
775+
setWasUserSectionChange(false);
777776
}}
778777
// prevent content scroll when elements outside the content are focused
779778
onFocus={() => {

packages/main/src/components/ObjectPage/useHandleTabSelect.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ interface UseHandleTabSelectProps {
2323
scrollTimeout: RefObject<number>;
2424
setSelectedSubSectionId: Dispatch<SetStateAction<string>>;
2525
setTabSelectId: Dispatch<SetStateAction<string | null>>;
26-
setUserSectionChange: Dispatch<SetStateAction<boolean>>;
26+
setWasUserSectionChange: Dispatch<SetStateAction<boolean>>;
2727
}
2828

2929
export const useHandleTabSelect = ({
@@ -42,7 +42,7 @@ export const useHandleTabSelect = ({
4242
scrollTimeout,
4343
setSelectedSubSectionId,
4444
setTabSelectId,
45-
setUserSectionChange,
45+
setWasUserSectionChange,
4646
}: UseHandleTabSelectProps) => {
4747
const [onSectionSelectedArgs, setOnSectionSelectedArgs] = useState<
4848
| false
@@ -109,7 +109,7 @@ export const useHandleTabSelect = ({
109109
}
110110

111111
if (mode === ObjectPageMode.IconTabBar) {
112-
setUserSectionChange(true);
112+
setWasUserSectionChange(true);
113113
}
114114
};
115115
// effect required - if event is called in `handleTabItemSelect` it's invoked twice in StrictMode

0 commit comments

Comments
 (0)