Skip to content

Commit ee07c7a

Browse files
authored
Merge branch 'main' into feat/ui5wc-v2.16.0
2 parents 00d54fc + 40ee1c7 commit ee07c7a

File tree

3 files changed

+56
-19
lines changed

3 files changed

+56
-19
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
path: packages
4949

5050
- name: Cypress run
51-
uses: cypress-io/github-action@e65cba2e7319696fc0fdc4d5a319b737aec4ba1c # v6.10.3
51+
uses: cypress-io/github-action@7ef72e250a9e564efb4ed4c2433971ada4cc38b4 # v6.10.4
5252
with:
5353
browser: chrome
5454
component: true

packages/main/src/components/AnalyticalTable/types/index.ts

Lines changed: 26 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,16 @@ export interface ColumnType extends Omit<AnalyticalTableColumnDefinition, 'id'>
9393
export interface CellType {
9494
column: ColumnType;
9595
row: RowType;
96-
value: string | undefined;
97-
getCellProps: (props?: any) => any;
96+
value: string | undefined | null;
97+
getCellProps: (userProps?: any) => any;
98+
/**
99+
* Indicates whether the cell is aggregated.
100+
*
101+
* __Note:__ This is a numeric flag where `1` means true and `0` means false.
102+
*/
103+
isAggregated: 0 | 1;
104+
isGrouped: boolean;
105+
isPlaceholder: boolean;
98106
[key: string]: any;
99107
}
100108

@@ -257,27 +265,33 @@ export interface WCRPropertiesType {
257265
onFilter: AnalyticalTablePropTypes['onFilter'];
258266
}
259267

260-
export type CellInstance = TableInstance & { cell: CellType } & Omit<CellType, 'getCellProps'>;
268+
export type CellInstance = TableInstance & { cell: CellType } & Omit<
269+
CellType,
270+
'getCellProps' | 'isAggregated' | 'isGrouped' | 'isPlaceholder'
271+
>;
261272

262273
export interface RowType {
263-
allCells: Record<string, any>[];
264274
canExpand: boolean;
265-
cells: Record<string, any>[];
275+
cells: CellType[];
276+
allCells: Record<string, any>[];
266277
depth: number;
267-
getRowProps: (props?: any) => any;
268-
getToggleRowExpandedProps: (userProps?: any) => any;
269-
getToggleRowSelectedProps: (userProps?: any) => any;
270278
id: string;
271279
index: number;
272-
isExpanded: boolean;
280+
isExpanded: boolean | undefined;
273281
isSelected: boolean;
274282
isSomeSelected: boolean;
283+
getRowProps: (props?: any) => any;
275284
original: Record<string, any>;
276285
originalSubRows: Record<string, any>[];
277-
subRows: Record<string, any>[];
278-
toggleRowExpanded: (isExpanded?: boolean) => void;
279-
toggleRowSelected: (isSelected?: boolean) => void;
286+
subRows: RowType[];
280287
values: Record<string, any>;
288+
groupByID?: string;
289+
groupByVal?: string;
290+
leafRows?: Omit<RowType, 'leafRows'>[];
291+
getToggleRowExpandedProps?: (userProps?: any) => any;
292+
getToggleRowSelectedProps?: (userProps?: any) => any;
293+
toggleRowExpanded?: (isExpanded?: boolean) => void;
294+
toggleRowSelected?: (isSelected?: boolean) => void;
281295
[key: string]: any;
282296
}
283297

packages/main/src/components/ObjectStatus/ObjectStatus.module.css

Lines changed: 29 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,30 @@
239239
}
240240

241241
&.active:focus {
242-
outline: var(--sapContent_FocusColor) var(--sapContent_FocusStyle) var(--sapContent_FocusWidth);
242+
outline: none;
243+
&::after {
244+
outline: none;
245+
content: '';
246+
position: absolute;
247+
box-sizing: border-box;
248+
inset: calc(-1 * var(--sapButton_BorderWidth));
249+
pointer-events: none;
250+
box-shadow:
251+
inset 0 0 0 0.125rem var(--sapContent_FocusColor),
252+
inset 0 0 0 0.1875rem var(--sapContent_ContrastFocusColor);
253+
border-radius: inherit;
254+
height: calc(100% + 2 * var(--sapButton_BorderWidth));
255+
}
256+
}
257+
}
258+
259+
/*deltas*/
260+
[data-sap-theme^='sap_'][data-sap-theme$='_hcw'] .inverted.active:focus,
261+
[data-sap-theme^='sap_'][data-sap-theme$='_hcb'] .inverted.active:focus {
262+
outline: var(--sapContent_FocusColor) var(--sapContent_FocusStyle) var(--sapContent_FocusWidth);
263+
outline-offset: var(--sapButton_BorderWidth);
264+
&::after {
265+
content: none;
243266
}
244267
}
245268

@@ -385,7 +408,7 @@
385408
.objectStatus:is(.inverted):is(.negative, .critical, .positive, .information, .none) {
386409
color: var(--_ui5wcr-ObjectStatus-inverted-vs-text-color);
387410
background: var(--_ui5wcr-ObjectStatus-inverted-vs-background-color);
388-
border: 0.0625rem solid var(--_ui5wcr-ObjectStatus-inverted-vs-border-color);
411+
border: var(--sapButton_BorderWidth) solid var(--_ui5wcr-ObjectStatus-inverted-vs-border-color);
389412

390413
[ui5-icon] {
391414
color: var(--_ui5wcr-ObjectStatus-inverted-vs-text-color);
@@ -394,7 +417,7 @@
394417
&.active:hover {
395418
color: var(--_ui5wcr-ObjectStatus-inverted-vs-hover-text-color);
396419
background: var(--_ui5wcr-ObjectStatus-inverted-vs-hover-background-color);
397-
border: 0.0625rem solid var(--_ui5wcr-ObjectStatus-inverted-vs-hover-border-color);
420+
border: var(--sapButton_BorderWidth) solid var(--_ui5wcr-ObjectStatus-inverted-vs-hover-border-color);
398421

399422
[ui5-icon] {
400423
color: var(--_ui5wcr-ObjectStatus-inverted-vs-hover-text-color);
@@ -405,7 +428,7 @@
405428
text-shadow: var(--sapContent_TextShadow);
406429
color: var(--_ui5wcr-ObjectStatus-inverted-vs-active-text-color);
407430
background: var(--_ui5wcr-ObjectStatus-inverted-vs-active-background-color);
408-
border: 0.0625rem solid var(--_ui5wcr-ObjectStatus-inverted-vs-active-border-color);
431+
border: var(--sapButton_BorderWidth) solid var(--_ui5wcr-ObjectStatus-inverted-vs-active-border-color);
409432

410433
[ui5-icon] {
411434
color: var(--_ui5wcr-ObjectStatus-inverted-vs-active-text-color);
@@ -685,7 +708,7 @@
685708
text-shadow: var(--sapContent_ContrastTextShadow);
686709
color: var(--_ui5wcr-ObjectStatus-inverted-indication-text-color);
687710
background-color: var(--_ui5wcr-ObjectStatus-inverted-indication-background-color);
688-
border: 0.0625rem solid var(--_ui5wcr-ObjectStatus-inverted-indication-border-color);
711+
border: var(--sapButton_BorderWidth) solid var(--_ui5wcr-ObjectStatus-inverted-indication-border-color);
689712

690713
[ui5-icon] {
691714
color: var(--_ui5wcr-ObjectStatus-inverted-indication-text-color);
@@ -699,7 +722,7 @@
699722
text-shadow: var(--sapContent_TextShadow);
700723
color: var(--_ui5wcr-ObjectStatus-inverted-indication-active-text-color);
701724
background: var(--_ui5wcr-ObjectStatus-inverted-indication-active-background-color);
702-
border: 0.0625rem solid var(--_ui5wcr-ObjectStatus-inverted-indication-active-border-color);
725+
border: var(--sapButton_BorderWidth) solid var(--_ui5wcr-ObjectStatus-inverted-indication-active-border-color);
703726

704727
[ui5-icon] {
705728
color: var(--_ui5wcr-ObjectStatus-inverted-indication-active-text-color);

0 commit comments

Comments
 (0)