Skip to content

Commit f4802ea

Browse files
authored
Merge branch 'main' into fix/at-row-cell-types
2 parents 8b33e5f + b8873cd commit f4802ea

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/chromatic.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
run: yarn install --immutable
2424

2525
- name: Publish to Chromatic
26-
uses: chromaui/action@bc2d84ad2b60813a67d995c5582d696104a19383 # v13.3.2
26+
uses: chromaui/action@ac86f2ff0a458ffbce7b40698abd44c0fa34d4b6 # v13.3.3
2727
with:
2828
token: ${{ secrets.GITHUB_TOKEN }}
2929
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}

packages/main/src/components/ObjectPage/ObjectPage.cy.tsx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -384,8 +384,8 @@ describe('ObjectPage', () => {
384384
cy.findByText('Test').should('be.visible');
385385

386386
cy.get('[ui5-tabcontainer]').findUi5TabByText('Employment').realClick();
387-
cy.get('[data-section-id="test"]').shouldNeverHaveAttribute('selected');
388-
cy.get('[data-section-id="personal"]').shouldNeverHaveAttribute('selected');
387+
cy.get('[data-section-id="test"]').shouldNeverHaveAttribute('selected', 300);
388+
cy.get('[data-section-id="personal"]').shouldNeverHaveAttribute('selected', 300);
389389
cy.get(`[ui5-tab][data-index="3"]`).should('have.attr', 'selected');
390390
cy.findByText('Employment').should('be.visible');
391391

@@ -440,18 +440,22 @@ describe('ObjectPage', () => {
440440
cy.wait(200);
441441
//fallback click
442442
cy.get('[ui5-tabcontainer]').findUi5TabByText('Employment').realClick();
443-
cy.get('[data-section-id="test"]').shouldNeverHaveAttribute('selected');
444-
cy.get('[data-section-id="personal"]').shouldNeverHaveAttribute('selected');
443+
cy.get('[data-section-id="test"]').shouldNeverHaveAttribute('selected', 500);
444+
cy.get('[data-section-id="personal"]').shouldNeverHaveAttribute('selected', 500);
445445
cy.findByTestId('footer').should('be.visible');
446446
cy.findByText('Employment').should('be.visible');
447447
cy.findByText('Job Information').should('be.visible');
448448

449+
cy.wait(200);
450+
449451
cy.get('[ui5-tabcontainer]').findUi5TabByText('Goals').click();
450452
cy.get('[data-section-id="test"]').shouldNeverHaveAttribute('selected', 300);
451-
cy.get('[data-section-id="personal"]').shouldNeverHaveAttribute('selected');
453+
cy.get('[data-section-id="personal"]').shouldNeverHaveAttribute('selected', 300);
452454
cy.findByText('Test').should('be.visible');
453455
cy.findByTestId('footer').should('be.visible');
454456

457+
cy.wait(300);
458+
455459
cy.get('[ui5-tabcontainer]').findUi5TabByText('Employment').focus();
456460
cy.realPress('ArrowDown');
457461
cy.wait(500);

0 commit comments

Comments
 (0)