VariantManagement: add nativeDetail again & fix tests

Author: Lukas742

packages/main/src/components/VariantManagement/VariantManagement.cy.tsx

@@ -391,10 +391,11 @@ describe('VariantManagement', () => {
   it('Save As', () => {
     const TestComp = ({ onSaveAs }: { onSaveAs: VariantManagementPropTypes['onSaveAs'] }) => {
       const [saved, setSaved] = useState(undefined);
-      const handleSaveAs = (e) => {
+      const handleSaveAs: VariantManagementPropTypes['onSaveAs'] = (e) => {
         onSaveAs(e);
-        const { variantItem: _0, ...rest } = e.detail;
-        setSaved(rest);
+        console.log(e.detail);
+        const { variantItem: _0, children, global, isDefault, nativeDetail, selected, applyAutomatically } = e.detail;
+        setSaved({ nativeDetail, selected, children, isDefault, global, applyAutomatically });
       };
       return (
         <>
@@ -494,11 +495,15 @@ describe('VariantManagement', () => {
       showOnlyFavorites?: VariantManagementPropTypes['showOnlyFavorites'];
     }) => {
       const [save, setSave] = useState(undefined);
-      const handleSave = (e) => {
+      const handleSave: VariantManagementPropTypes['onSaveManageViews'] = (e) => {
+        const { deletedVariants, prevVariants, updatedVariants, variants, nativeDetail } = e.detail;
         onSaveManageViews(e);
         setSave({
-          ...e.detail,
-          variants: e.detail.variants.map((item) => {
+          nativeDetail,
+          deletedVariants,
+          prevVariants,
+          updatedVariants,
+          variants: variants.map((item) => {
             const { variantItem: _0, ...rest } = item;
             return rest;
           }),
@@ -631,11 +636,15 @@ describe('VariantManagement', () => {
       onSaveManageViews: VariantManagementPropTypes['onSaveManageViews'];
     }) => {
       const [save, setSave] = useState(undefined);
-      const handleSave = (e) => {
+      const handleSave: VariantManagementPropTypes['onSaveManageViews'] = (e) => {
+        const { deletedVariants, prevVariants, updatedVariants, variants, nativeDetail } = e.detail;
         onSaveManageViews(e);
         setSave({
-          ...e.detail,
-          variants: e.detail.variants.map((item) => {
+          nativeDetail,
+          deletedVariants,
+          prevVariants,
+          updatedVariants,
+          variants: variants.map((item) => {
             const { variantItem: _0, ...rest } = item;
             return rest;
           }),

packages/main/src/components/VariantManagement/index.tsx

@@ -208,7 +208,8 @@ const VariantManagement = forwardRef<HTMLDivElement, VariantManagementPropTypes>
 
   const handleSaveView = (e, selectedVariant) => {
     if (typeof onSaveAs === 'function') {
-      onSaveAs(enrichEventWithDetails(e, selectedVariant));
+      //todo: remove nativeDetail in next major
+      onSaveAs(enrichEventWithDetails(e, { ...selectedVariant, nativeDetail: e.detail.originalEvent.detail }));
     }
     setSelectedVariant(selectedVariant);
     if (!e.defaultPrevented) {
@@ -218,7 +219,13 @@ const VariantManagement = forwardRef<HTMLDivElement, VariantManagementPropTypes>
 
   const handleSaveManageViews = (e, payload) => {
     const { defaultView, updatedRows, deletedRows } = payload;
-    const callbackProperties = { deletedVariants: [], prevVariants: [], updatedVariants: [], variants: [] };
+    const callbackProperties = {
+      deletedVariants: [],
+      prevVariants: [],
+      updatedVariants: [],
+      variants: [],
+      nativeDetail: null,
+    };
     setSafeChildren((prev) =>
       Children.toArray(
         prev.map((child) => {
@@ -260,6 +267,8 @@ const VariantManagement = forwardRef<HTMLDivElement, VariantManagementPropTypes>
       ),
     );
     if (typeof onSaveManageViews === 'function') {
+      //todo: remove in next major
+      callbackProperties.nativeDetail = e.detail.originalEvent.detail;
       onSaveManageViews(enrichEventWithDetails(e, callbackProperties));
     }
     if (!e.defaultPrevented) {