Skip to content

Commit fd282a2

Browse files
committed
docs adjustments
1 parent 7bffd12 commit fd282a2

File tree

5 files changed

+22
-12
lines changed

5 files changed

+22
-12
lines changed

.storybook/components/DocsHeader.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import {
1616
} from '@ui5/webcomponents-react';
1717
import { clsx } from 'clsx';
1818
import type { ComponentProps } from 'react';
19+
import { Fragment } from 'react';
1920
import { useGetSubComponentsOfModule } from '../utils';
2021
import classes from './DocsHeader.module.css';
2122
import { GitHubLogo } from './GitHub-Mark';
@@ -143,10 +144,10 @@ export const InfoTable = ({
143144
</th>
144145
<td data-import-cell={supportsClipboardApi}>
145146
{subComps.map((subComp) => (
146-
<>
147-
<Import key={subComp} moduleName={subComp} componentId={preparedMeta.componentId} />
147+
<Fragment key={subComp}>
148+
<Import moduleName={subComp} componentId={preparedMeta.componentId} />
148149
<br />
149-
</>
150+
</Fragment>
150151
))}
151152
{supportsClipboardApi && (
152153
<Button

.storybook/manager.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ addons.setConfig({
6464
const isExperimental = tags.includes('experimental');
6565
const isDeprecated = tags.includes('deprecated');
6666

67-
if (item.type !== 'component' && item.type !== 'docs') {
67+
if ((item.type !== 'component' && item.type !== 'docs') || (item.type === 'docs' && item.name === 'Docs')) {
6868
return item.name;
6969
}
7070

packages/main/src/components/AnalyticalTable/AnalyticalTable.stories.tsx

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -607,13 +607,18 @@ export const NoData: Story = {
607607
}
608608
/>
609609
) : (
610-
<ToggleableTable
611-
{...args}
612-
data={selected === 'data' ? args.data : []}
613-
NoDataComponent={
614-
selected === 'noData' ? undefined : () => <IllustratedMessage role="gridcell" name={NoDataIllustration} />
615-
}
616-
/>
610+
<>
611+
<hr />
612+
<ToggleableTable
613+
{...args}
614+
data={selected === 'data' ? args.data : []}
615+
NoDataComponent={
616+
selected === 'noData'
617+
? undefined
618+
: () => <IllustratedMessage role="gridcell" name={NoDataIllustration} />
619+
}
620+
/>
621+
</>
617622
)}
618623
</>
619624
);

packages/main/src/components/AnalyticalTable/AnalyticalTableHooks.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { ImportStatement } from '@sb/components/Import';
1111
We're offering plugin hooks to extend the functionality of the `AnalyticalTable` component. The following hooks are available:
1212

1313
- [useAnnounceEmptyCells](?path=/docs/data-display-analyticaltable-plugin-hooks-useannounceemptycells--docs)
14+
- [useF2CellEdit](?path=/docs/data-display-analyticaltable-plugin-hooks-usef2celledit--docs)
1415
- [useIndeterminateRowSelection](?path=/docs/data-display-analyticaltable-plugin-hooks-useindeterminaterowselection--docs)
1516
- [useManualRowSelect](?path=/docs/data-display-analyticaltable-plugin-hooks-usemanualrowselect--docs)
1617
- [useOnColumnResize](?path=/docs/data-display-analyticaltable-plugin-hooks-useoncolumnresize--docs)

packages/main/src/components/AnalyticalTable/types/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,10 @@ export interface AnalyticalTablePropTypes extends Omit<CommonProps, 'title'> {
10331033
/**
10341034
* Component that will be rendered when the table is not loading and has no data.
10351035
*
1036-
* __Note:__ Although this prop accepts all React components, it is strongly recommended that you use `IllustratedMessage` with `design="Auto"` to preserve the intended design.
1036+
* __Note:__
1037+
* - Although this prop accepts all React components, it is strongly recommended that you use `IllustratedMessage` with `design="Auto"` to preserve the intended design.
1038+
* - For `visibleRowCountMode`s "Auto" and "AutoWithEmptyRows", the `NoDataComponent` spreads to the available space below the header row, otherwise the `minRows` prop defines the minimum height of the table body.
1039+
* - To prevent overflow, ensure the table body is at least **60 px** tall when displaying an `IllustratedMessage`.
10371040
*
10381041
* @default DefaultNoDataComponent
10391042
*/

0 commit comments

Comments
 (0)