Skip to content

fix(VariantManagement): fix dirty-state and readOnly behavior #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lukas742 merged 2 commits into from
Nov 18, 2024
Merged

fix(VariantManagement): fix dirty-state and readOnly behavior #6628

Lukas742 merged 2 commits into from
Nov 18, 2024

Conversation

@superdyzio
Copy link
Contributor

@superdyzio superdyzio commented Nov 17, 2024 •
edited by Lukas742
Loading

Fixes #6622
Fixes #6617

Thank you for your contribution! 👏

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@cla-assistant
Copy link

cla-assistant bot commented Nov 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

superdyzio
superdyzio commented Nov 17, 2024
View reviewed changes
Lukas742
Lukas742 requested changes Nov 18, 2024
View reviewed changes
@Lukas742 Lukas742 changed the title fix(VariantManagement): add checking for selectedVariant in showSaveBtn fix(VariantManagement): fix dirty-state and readOnly behavior Nov 18, 2024
@coveralls
Copy link

coveralls commented Nov 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11896713120

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 87.138%
Totals Coverage Status
Change from base Build 11896594917: 0.002%
Covered Lines: 5054
Relevant Lines: 5800
💛 - Coveralls

@superdyzio superdyzio force-pushed the bugfix/6622-variant-managament-empty-and-dirty branch from 48b4de5 to 6263f5c Compare November 18, 2024 16:26
@superdyzio superdyzio requested a review from Lukas742 November 18, 2024 16:26
Lukas742
Lukas742 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Lukas742 Lukas742 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢
Thanks for the contribution!

The failing test is using an rc version of React 19, so we're good to merge this as React19 isn't stable yet. We'll look into it ASAP.

@Lukas742 Lukas742 merged commit fe389bc into UI5:main Nov 18, 2024
22 of 23 checks passed
@ui5-webcomponents-react-bot
Copy link
Collaborator

ui5-webcomponents-react-bot commented Dec 9, 2024

🎉 This PR is included in version v2.5.0 🎉

The release is available on v2.5.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lukas742 Lukas742 Lukas742 approved these changes

@MarcusNotheis MarcusNotheis Awaiting requested review from MarcusNotheis MarcusNotheis is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VariantManagament: breaks when array of variants is empty VariantManagament: Missing button to save changes to already saved view

4 participants

@superdyzio @coveralls @ui5-webcomponents-react-bot @Lukas742