Skip to content

Commit 0b3a47b

Browse files
fix(ui5-side-navigation): change CSS param 'sapFontSemiboldFamily' to 'sapFontSemiboldDuplexFamily' (#11529)
Problem: the 'sapFontSemiboldFamily' parameter did not result in a change in the font since font '72-Semibold' doesn't load. Solution: replace it with 'sapFontSemiboldDuplexFamily' Fixes: #11525
1 parent d6ee5ea commit 0b3a47b

File tree

8 files changed

+3
-7
lines changed

8 files changed

+3
-7
lines changed

packages/fiori/src/themes/NavigationMenuItem.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
transition: var(--_ui5_side_navigation_item_transition);
1616
color: var(--sapList_TextColor);
1717
font-size: var(--sapFontSize);
18-
font-family: var(--_ui5_side_navigation_item_font_family);
18+
font-family: var(--_ui5_side_navigation_parent_item_font_family);
1919
}
2020

2121
::slotted([ui5-navigation-menu-item]) {

packages/fiori/src/themes/SideNavigationGroup.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
:host {
44
font-size: var(--sapFontSmallSize);
5-
font-family: var(--sapFontSemiboldFamily);
65
color: var(--sapContent_LabelColor);
76
}
87

packages/fiori/src/themes/SideNavigationItem.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@
2525
}
2626

2727
.ui5-sn-item-level1 .ui5-sn-item-text {
28-
font-weight: bold;
28+
font-family: var(--_ui5_side_navigation_parent_item_font_family);
2929
}

packages/fiori/src/themes/base/SideNavigation-parameters.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
--_ui5_side_navigation_group_icon_width: var(--_ui5_side_navigation_collapsed_width);
4444
--_ui5_side_navigation_icon_padding_inline_end: 1rem;
4545
--_ui5_side_navigation_item_font_family: "72override", var(--sapFontFamily);
46+
--_ui5_side_navigation_parent_item_font_family: "72override", var(--sapFontSemiboldDuplexFamily);
4647
--_ui5_side_navigation_group_padding: 0.5rem;
4748
--_ui5_side_navigation_padding-flexible: 0;
4849
--_ui5_side_navigation_padding-fixed: 0;

packages/fiori/src/themes/sap_horizon/SideNavigation-parameters.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
--_ui5_side_navigation_selected_and_focused_border_style_color: var(--_ui5_side_navigation_selected_border_style_color);
3333
--_ui5_side_navigation_group_icon_width: 2.5rem;
3434
--_ui5_side_navigation_icon_padding_inline_end: 0.5rem;
35-
--_ui5_side_navigation_item_font_family: "72override", var(--sapFontSemiboldFamily);
3635
--_ui5_side_navigation_group_padding: 1rem;
3736
--_ui5_side_navigation_padding-flexible: 0.5rem 0.5rem 0 0.5rem;
3837
--_ui5_side_navigation_padding-fixed: 0 0.5rem 0.5rem 0.5rem;

packages/fiori/src/themes/sap_horizon_dark/SideNavigation-parameters.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
--_ui5_side_navigation_selected_and_focused_border_style_color: var(--_ui5_side_navigation_selected_border_style_color);
3333
--_ui5_side_navigation_group_icon_width: 2.5rem;
3434
--_ui5_side_navigation_icon_padding_inline_end: 0.5rem;
35-
--_ui5_side_navigation_item_font_family: var(--sapFontSemiboldFamily);
3635
--_ui5_side_navigation_group_padding: 1rem;
3736
--_ui5_side_navigation_padding-flexible: 0.5rem 0.5rem 0 0.5rem;
3837
--_ui5_side_navigation_padding-fixed: 0 0.5rem 0.5rem 0.5rem;

packages/fiori/src/themes/sap_horizon_hcb/SideNavigation-parameters.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
--_ui5_side_navigation_selected_and_focused_border_style_color: none;
3131
--_ui5_side_navigation_group_icon_width: 2.5rem;
3232
--_ui5_side_navigation_icon_padding_inline_end: 0.5rem;
33-
--_ui5_side_navigation_item_font_family: "72override", var(--sapFontSemiboldFamily);
3433
--_ui5_side_navigation_group_padding: 1rem;
3534
--_ui5_side_navigation_padding-flexible: 0.5rem 0.5rem 0 0.5rem;
3635
--_ui5_side_navigation_padding-fixed: 0 0.5rem 0.5rem 0.5rem;

packages/fiori/src/themes/sap_horizon_hcw/SideNavigation-parameters.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
--_ui5_side_navigation_selected_and_focused_border_style_color: none;
3131
--_ui5_side_navigation_group_icon_width: 2.5rem;
3232
--_ui5_side_navigation_icon_padding_inline_end: 0.5rem;
33-
--_ui5_side_navigation_item_font_family: "72override", var(--sapFontSemiboldFamily);
3433
--_ui5_side_navigation_group_padding: 1rem;
3534
--_ui5_side_navigation_padding-flexible: 0.5rem 0.5rem 0 0.5rem;
3635
--_ui5_side_navigation_padding-fixed: 0 0.5rem 0.5rem 0.5rem;

0 commit comments

Comments
 (0)