Skip to content

Commit 16438a6

Browse files
authored
chore: rewrite imports with file extensions (#344)
Rewrite all imports across all packages (core, base and main) with file extensions and force writing them this way by adding an eslint rule. Example: import WebComponent from "@ui5/webcomponents-base/src/WebComponent.js"; import ButtonRenderer from "./build/compiled/ButtonRenderer.lit.js"; import buttonCss from "./themes/Button.css.js"; * Packages are ignored: import { render } from "lit-html"; * The eslint rule is: "import/extensions": ["error", "ignorePackages"]
1 parent 2cf5e31 commit 16438a6

File tree

132 files changed

+636
-634
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

132 files changed

+636
-634
lines changed

packages/base/.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ module.exports = {
1111
},
1212
"rules": {
1313
"comma-dangle": [2, "always-multiline"], // difference from openui5
14+
"import/extensions": ["error", "ignorePackages"], // override for UI5 WebComponents
1415
"no-cond-assign": 2,
1516
"no-console": 2,
1617
"no-constant-condition": 2,

packages/base/src/Bootstrap.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import whenDOMReady from "./util/whenDOMReady";
2-
import EventEnrichment from "./events/EventEnrichment";
3-
import { insertIconFontFace } from "./IconFonts";
4-
import DOMEventHandler from "./DOMEventHandler";
5-
import { initConfiguration } from "./Configuration";
6-
import { applyTheme } from "./Theming";
7-
import whenPolyfillLoaded from "./compatibility/whenPolyfillLoaded";
1+
import whenDOMReady from "./util/whenDOMReady.js";
2+
import EventEnrichment from "./events/EventEnrichment.js";
3+
import { insertIconFontFace } from "./IconFonts.js";
4+
import DOMEventHandler from "./DOMEventHandler.js";
5+
import { initConfiguration } from "./Configuration.js";
6+
import { applyTheme } from "./Theming.js";
7+
import whenPolyfillLoaded from "./compatibility/whenPolyfillLoaded.js";
88

99
EventEnrichment.run();
1010

packages/base/src/CLDR.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ import zh_HK from "@ui5/webcomponents-core/dist/sap/ui/core/cldr/zh_HK.json";
7373
import zh_SG from "@ui5/webcomponents-core/dist/sap/ui/core/cldr/zh_SG.json";
7474
import zh_TW from "@ui5/webcomponents-core/dist/sap/ui/core/cldr/zh_TW.json";
7575

76-
import { registerModuleContent } from "./ResourceLoaderOverrides";
77-
import { fetchTextOnce } from "./util/FetchHelper";
76+
import { registerModuleContent } from "./ResourceLoaderOverrides.js";
77+
import { fetchTextOnce } from "./util/FetchHelper.js";
7878

7979
const cldrData = {
8080
ar,

packages/base/src/CSS.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { getTheme } from "./Configuration";
2-
import { getEffectiveStyle } from "./Theming";
1+
import { getTheme } from "./Configuration.js";
2+
import { getEffectiveStyle } from "./Theming.js";
33

44
const styleMap = new Map();
55

packages/base/src/Configuration.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import CalendarType from "@ui5/webcomponents-core/dist/sap/ui/core/CalendarType";
2-
import getDesigntimePropertyAsArray from "./util/getDesigntimePropertyAsArray";
1+
import CalendarType from "@ui5/webcomponents-core/dist/sap/ui/core/CalendarType.js";
2+
import getDesigntimePropertyAsArray from "./util/getDesigntimePropertyAsArray.js";
33

44
const CONFIGURATION = {
55
theme: "sap_fiori_3",

packages/base/src/ControlRenderer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import LitRenderer from "./renderer/LitRenderer";
1+
import LitRenderer from "./renderer/LitRenderer.js";
22

33
const RendererImpl = LitRenderer;
44

packages/base/src/DOMEventHandler.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import ControlEvents from "./events/ControlEvents";
2-
import getOriginalEventTarget from "./events/getOriginalEventTarget";
3-
import WebComponent from "./WebComponent";
1+
import ControlEvents from "./events/ControlEvents.js";
2+
import getOriginalEventTarget from "./events/getOriginalEventTarget.js";
3+
import WebComponent from "./WebComponent.js";
44

55
const handleEvent = function handleEvent(event) {
66
// Get the DOM node where the original event occurred

packages/base/src/FocusHelper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import WebComponent from "./WebComponent";
1+
import WebComponent from "./WebComponent.js";
22

33
const rFocusable = /^(?:input|select|textarea|button)$/i,
44
rClickable = /^(?:a|area)$/i;

packages/base/src/FormatSettings.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import Locale from "./Locale";
2-
import { getLocale } from "./LocaleProvider";
1+
import Locale from "./Locale.js";
2+
import { getLocale } from "./LocaleProvider.js";
33

44
const mSettings = {};
55

packages/base/src/IconPool.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import URI from "@ui5/webcomponents-core/dist/sap/ui/thirdparty/URI";
1+
import URI from "@ui5/webcomponents-core/dist/sap/ui/thirdparty/URI.js";
22
/* eslint-disable */
33

44
const SAP_ICON_FONT_FAMILY = 'SAP-icons';

0 commit comments

Comments
 (0)