Skip to content

Commit 1709455

Browse files
fifoosidpskelin
authored andcommitted
refactor: skip warning when element is defined locally (#527)
1 parent ff59a98 commit 1709455

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

packages/base/src/UI5Element.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ const metadata = {
1313
},
1414
};
1515

16+
const DefinitionsSet = new Set();
1617
const IDMap = new Map();
1718

1819
class UI5Element extends HTMLElement {
@@ -274,11 +275,15 @@ class UI5Element extends HTMLElement {
274275
static define() {
275276
const tag = this.getMetadata().getTag();
276277

277-
if (!customElements.get(tag)) {
278+
const definedLocally = DefinitionsSet.has(tag);
279+
const definedGlobally = customElements.get(tag);
280+
281+
if (definedGlobally && !definedLocally) {
282+
console.warn(`Skipping definition of tag ${tag}, because it was already defined by another instance of ui5-webcomponents.`); // eslint-disable-line
283+
} else if (!definedGlobally) {
278284
this.generateAccessors();
285+
DefinitionsSet.add(tag);
279286
window.customElements.define(tag, this);
280-
} else {
281-
console.warn(`Skipping definition of tag ${tag}, because it was already defined.`); // eslint-disable-line
282287
}
283288
return this;
284289
}

0 commit comments

Comments
 (0)