Skip to content

Commit 74aa404

Browse files
fix(ui5-date-picker): apply value format in event detail (#12615)
Fixes an issue where the ui5-date-picker component was not applying the correct value format in event details when the valueFormat property is used. fixes: #12580
1 parent 086a92a commit 74aa404

File tree

2 files changed

+28
-1
lines changed

2 files changed

+28
-1
lines changed

packages/main/cypress/specs/DatePicker.cy.tsx

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,6 +1442,33 @@ describe("Date Picker Tests", () => {
14421442
});
14431443
});
14441444

1445+
it("change event fires with value in correct valueFormat", () => {
1446+
cy.mount(<DatePicker displayFormat="MMM d, y" valueFormat="yyyy-MM-dd"></DatePicker>);
1447+
1448+
cy.get("[ui5-date-picker]")
1449+
.as("datePicker")
1450+
.then($datePicker => {
1451+
$datePicker.on("change", cy.stub().as("changeHandler"));
1452+
});
1453+
1454+
cy.get<DatePicker>("@datePicker")
1455+
.ui5DatePickerGetInnerInput()
1456+
.realClick()
1457+
.should("be.focused")
1458+
.realType("Mar 31, 2024")
1459+
.realPress("Enter");
1460+
1461+
cy.get<DatePicker>("@datePicker")
1462+
.should("have.value", "2024-03-31");
1463+
1464+
cy.get("@changeHandler")
1465+
.should("have.been.calledOnce")
1466+
.its("firstCall.args.0.detail")
1467+
.should("deep.include", {
1468+
value: "2024-03-31"
1469+
});
1470+
});
1471+
14451472
it("DatePicker's formatter has strict parsing enabled", () => {
14461473
cy.mount(<DatePicker formatPattern="MMM d, y"></DatePicker>);
14471474

packages/main/src/DatePicker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ class DatePicker extends DateComponentBase implements IFormInputElement {
590590
}
591591

592592
events.forEach(e => {
593-
if (!this.fireDecoratorEvent(e, { value, valid })) {
593+
if (!this.fireDecoratorEvent(e, { value: this.value, valid })) {
594594
executeEvent = false;
595595
}
596596
});

0 commit comments

Comments
 (0)