Skip to content

Commit 87cd3c7

Browse files
fix(ui5-search): show delete button on item hover (#11850)
1 parent 69627b4 commit 87cd3c7

File tree

3 files changed

+29
-4
lines changed

3 files changed

+29
-4
lines changed

packages/fiori/cypress/specs/Search.cy.tsx

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,32 @@ describe("Properties", () => {
389389
.find("ui5-avatar")
390390
.should("be.visible");
391391
});
392+
393+
it("displays item's delete button on hover", () => {
394+
cy.mount(
395+
<Search>
396+
<SearchItem text="Item 1"/>
397+
<SearchItem text="Item 2"/>
398+
</Search>
399+
);
400+
401+
cy.get("[ui5-search]")
402+
.shadow()
403+
.find("input")
404+
.realClick();
405+
406+
cy.realPress("I");
407+
408+
cy.get("[ui5-search-item]")
409+
.eq(1)
410+
.realHover();
411+
412+
cy.get("[ui5-search-item]")
413+
.eq(1)
414+
.shadow()
415+
.find(".ui5-search-item-selected-delete")
416+
.should("be.visible");
417+
});
392418
});
393419

394420
describe("Events", () => {

packages/fiori/src/SearchItemTemplate.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ export default function SearchFieldTemplate(this: SearchItem) {
4343

4444
<span part="subtitle" class="ui5-search-item-description">{this.description}</span>
4545
</div>
46-
{this.selected &&
47-
<Button class="ui5-search-item-selected-delete" design={ButtonDesign.Transparent} icon={decline} onClick={this._onDeleteButtonClick}></Button>
48-
}
46+
<Button class="ui5-search-item-selected-delete" design={ButtonDesign.Transparent} icon={decline} onClick={this._onDeleteButtonClick}></Button>
4947
</div>
5048
</div>
5149
</li >

packages/fiori/src/themes/SearchItem.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
}
3030

3131
:host([selected]:hover),
32-
:host(:focus-within) {
32+
:host(:focus-within),
33+
:host(:hover) {
3334
.ui5-search-item-selected-delete {
3435
display: inline-block;
3536
}

0 commit comments

Comments
 (0)