Skip to content

Commit e9fa794

Browse files
fix(ui5-slider/ui5-range-slider): add border to progress indicator (#12653)
1 parent 7df4b03 commit e9fa794

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

packages/main/src/themes/SliderBase.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
height: var(--_ui5_slider_progress_height);
7373
position: relative;
7474
outline: none;
75-
box-sizing: border-box;
75+
box-sizing: var(--_ui5_slider_active_progress_box_sizing);
7676
border: var(--_ui5_slider_active_progress_border);
7777
left: var(--_ui5_slider_active_progress_left);
7878
top: var(--_ui5_slider_active_progress_top);

packages/main/src/themes/base/SliderBase-parameters.css

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
--_ui5_slider_progress_container_background: var(--sapField_BorderColor);
44
--_ui5_slider_progress_container_dot_display: none;
55
--_ui5_slider_progress_container_dot_background: var(--sapField_BorderColor);
6-
--_ui5_slider_progress_border: none;
6+
--_ui5_slider_progress_border: solid 0.0625rem var(--sapSlider_BorderColor);
77
--_ui5_slider_padding: 1.406rem 1.0625rem;
88
--_ui5_slider_inner_height: 0.25rem;
99
--_ui5_slider_outer_height: 1.6875rem;
@@ -63,15 +63,16 @@
6363
--_ui5_range_slider_root_active_handle_icon_display: none;
6464
--_ui5_slider_tickmark_height: 1rem;
6565
--_ui5_slider_tickmark_top: -.3125rem;
66-
--_ui5_slider_progress_box_sizing: content-box;
66+
--_ui5_slider_progress_box_sizing: border-box;
67+
--_ui5_slider_active_progress_box_sizing: content-box;
6768
--_ui5_slider_tickmark_in_range_bg: var(--sapField_BorderColor);
6869
--_ui5_range_slider_focus_outline_width: 100%;
6970
--_ui5_slider_progress_outline_offset_left: 0;
7071
--_ui5_range_slider_focus_outline_radius: 0;
7172

7273
--_ui5_slider_progress_container_top: 0;
7374
--_ui5_slider_progress_height: 100%;
74-
--_ui5_slider_active_progress_border: none;
75+
--_ui5_slider_active_progress_border: solid 0.0625rem var(--sapSlider_Selected_BorderColor);
7576
--_ui5_slider_active_progress_left: 0;
7677
--_ui5_slider_active_progress_top: 0;
7778

packages/main/src/themes/sap_horizon_hcb/SliderBase-parameters.css

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
--_ui5_range_slider_root_hover_handle_bg: var(--sapButton_Hover_Background);
2020
--_ui5_range_slider_handle_active_background: var(--sapSlider_Active_RangeHandleBackground);
2121
--_ui5_slider_inner_height: 0.25rem;
22-
--_ui5_slider_progress_border: solid 0.0625rem var(--sapContent_MeasureIndicatorColor);
2322
--_ui5_slider_progress_border_radius: 0.25rem;
2423
--_ui5_slider_progress_background: var(--sapSlider_Selected_Background);
2524
--_ui5_slider_progress_container_background: var(--sapSlider_Background);
@@ -38,10 +37,10 @@
3837
--_ui5_slider_tickmark_height: .5rem;
3938
--_ui5_slider_tickmark_top: -.125rem;
4039
--_ui5_slider_progress_box_sizing: border-box;
40+
--_ui5_slider_active_progress_box_sizing: border-box;
4141

4242
--_ui5_slider_progress_container_top: .0625rem;
4343
--_ui5_slider_progress_height: .375rem;
44-
--_ui5_slider_active_progress_border: .0625rem solid var(--sapSlider_Selected_BorderColor);
4544
--_ui5_slider_active_progress_left: -.0625rem;
4645
--_ui5_slider_active_progress_top: -.15625rem;
4746

packages/main/src/themes/sap_horizon_hcw/SliderBase-parameters.css

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
--_ui5_range_slider_root_hover_handle_bg: var(--sapButton_Hover_Background);
2020
--_ui5_range_slider_handle_active_background: var(--sapSlider_Active_RangeHandleBackground);
2121
--_ui5_slider_inner_height: 0.25rem;
22-
--_ui5_slider_progress_border: solid 0.0625rem var(--sapContent_MeasureIndicatorColor);
2322
--_ui5_slider_progress_border_radius: 0.25rem;
2423
--_ui5_slider_progress_background: var(--sapSlider_Selected_Background);
2524
--_ui5_slider_progress_container_background: var(--sapSlider_Background);
@@ -38,10 +37,10 @@
3837
--_ui5_slider_tickmark_height: .5rem;
3938
--_ui5_slider_tickmark_top: -.125rem;
4039
--_ui5_slider_progress_box_sizing: border-box;
40+
--_ui5_slider_active_progress_box_sizing: border-box;
4141

4242
--_ui5_slider_progress_container_top: .0625rem;
4343
--_ui5_slider_progress_height: .375rem;
44-
--_ui5_slider_active_progress_border: .0625rem solid var(--sapSlider_Selected_BorderColor);
4544
--_ui5_slider_active_progress_left: -.0625rem;
4645
--_ui5_slider_active_progress_top: -.15625rem;
4746

0 commit comments

Comments
 (0)