Skip to content

Commit fcb71f4

Browse files
authored
refactor(styles): use :dir(rtl|ltr) instead of dir="rtl"ltr" (#12766)
1 parent 00803e6 commit fcb71f4

File tree

7 files changed

+22
-17
lines changed

7 files changed

+22
-17
lines changed

packages/fiori/src/themes/ShellBar.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,11 +406,11 @@ slot[name="profile"] {
406406
}
407407

408408
.ui5-shellbar-overflow-container-right-child .ui5-shellbar-bell-button [slot="badge"] {
409-
inset-inline-end: var(--_ui5-shellbar-notification-btn-count-offset);
409+
inset-inline-end: var(--_ui5_shellbar_notification_btn_count_offset);
410410
}
411411

412412
.ui5-shellbar-overflow-container-right-child .ui5-shellbar-custom-item [slot="badge"] {
413-
inset-inline-end: var(--_ui5-shellbar-notification-btn-count-offset);
413+
inset-inline-end: var(--_ui5_shellbar_notification_btn_count_offset);
414414
}
415415

416416
.ui5-shellbar-menu-button {

packages/fiori/src/themes/base/SideNavigation-parameters.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,3 @@
7575
--_ui5_side_navigation_item_expand_arrow_padding: 0.3125rem;
7676
--_ui5_side_navigation_item_margin: 0.5rem;
7777
}
78-
79-
[dir="rtl"] {
80-
--_ui5_side_navigation_item_expand_icon_hover_left: 0;
81-
--_ui5_side_navigation_item_expand_icon_hover_right: auto;
82-
}
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
:root,
2+
:dir(ltr) {
3+
--_ui5_timeline_scroll_container_offset: 0.5rem;
4+
--_ui5_shellbar_notification_btn_count_offset: 0.125rem;
5+
--_ui5_side_navigation_item_expand_icon_hover_left: auto;
6+
--_ui5_side_navigation_item_expand_icon_hover_right: 0;
7+
}
8+
9+
:dir(rtl) {
10+
--_ui5_timeline_scroll_container_offset: -0.5rem;
11+
--_ui5_shellbar_notification_btn_count_offset: auto;
12+
--_ui5_side_navigation_item_expand_icon_hover_left: 0;
13+
--_ui5_side_navigation_item_expand_icon_hover_right: auto;
14+
}

packages/fiori/src/themes/sap_horizon/parameters-bundle.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
@import "../base/rtl-parameters.css";
12
@import "../base/FlexibleColumnLayout-parameters.css";
23
@import "../base/IllustratedMessage-parameters.css";
34
@import "../base/MediaGallery-parameters.css";

packages/main/src/themes/base/rtl-parameters.css

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
:root, [dir="ltr"] {
1+
:root,
2+
:dir(ltr) {
23
--_ui5_rotation_90deg: rotate(90deg);
34
--_ui5_rotation_minus_90deg: rotate(-90deg);
45

56
--_ui5_icon_transform_scale: none;
67
--_ui5_panel_toggle_btn_rotation: var(--_ui5_rotation_90deg);
7-
--_ui5_timeline_scroll_container_offset: 0.5rem;
88

99
--_ui5_popover_upward_arrow_margin: 0.1875rem 0 0 0.1875rem;
1010
--_ui5_popover_right_arrow_margin: 0.1875rem 0 0 -0.375rem;
@@ -15,15 +15,11 @@
1515
--_ui5_progress_indicator_bar_border_radius: 0.5rem 0 0 0.5rem;
1616
--_ui5_progress_indicator_remaining_bar_border_radius: 0 0.5rem 0.5rem 0;
1717
--_ui5_menu_submenu_margin_offset: -0.25rem 0;
18-
19-
--_ui5-shellbar-notification-btn-count-offset: 0.125rem;
2018
}
2119

22-
[dir="rtl"],
23-
[dir="rtl"] :host {
20+
:dir(rtl) {
2421
--_ui5_icon_transform_scale: scale(-1, 1);
2522
--_ui5_panel_toggle_btn_rotation: var(--_ui5_rotation_minus_90deg);
26-
--_ui5_timeline_scroll_container_offset: -0.5rem;
2723

2824
--_ui5_popover_upward_arrow_margin: .1875rem .125rem 0 0;
2925
--_ui5_popover_right_arrow_margin: .1875rem .25rem 0 0;
@@ -38,5 +34,4 @@
3834

3935
--_ui5_segmented_btn_item_border_left: 0.0625rem;
4036
--_ui5_segmented_btn_item_border_right: 0px;
41-
--_ui5-shellbar-notification-btn-count-offset: auto;
4237
}

packages/main/src/themes/sap_horizon/rtl-parameters.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
@import "../base/rtl-parameters.css";
22

3-
[dir="rtl"] {
3+
:dir(rtl) {
44
--_ui5_segmented_btn_item_border_left: 0.0625rem;
55
--_ui5_segmented_btn_item_border_right: 0.0625rem;
66
--_ui5_progress_indicator_bar_border_radius: 0.5rem;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
@import "../base/rtl-parameters.css";
22

3-
[dir="rtl"] {
3+
:dir(rtl) {
44
--_ui5_segmented_btn_item_border_left: 0.0625rem;
55
--_ui5_segmented_btn_item_border_right: 0.0625rem;
66
}

0 commit comments

Comments
 (0)