fix(ui5-*): improve vertical alignment of inline web comps#12718
Merged
fix(ui5-*): improve vertical alignment of inline web comps#12718
vertical alignment of inline web comps#12718Conversation
ilhan007
requested review from
TeodorTaushanov,
dobrinyonkov,
nnaydenow,
pskelin,
tsanislavgatev and
vladitasev
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12718--ui5-webcomponents.netlify.app |
Member
|
Text change looks good to me. |
Contributor
|
CheckBox looks fine :) |
nnaydenow
reviewed
Dec 2, 2025
Contributor
|
Components on my end look good. |
MapTo0
approved these changes
Dec 9, 2025
nnaydenow
approved these changes
Dec 11, 2025
ilhan007
changed the title
vertical alignment of inline web comps
Collaborator
|
🎉 This PR is included in version v2.18.0-rc.1 🎉 The release is available on v2.18.0-rc.1 Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version v2.18.0 🎉 The release is available on v2.18.0 Your semantic-release bot 📦🚀 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve vertical alignment of inline web comps by forcing same
vertical-align(vertical-align: middle in this case brought by FormComponents.css).Fixes: #12620
Before:
After
Changes
vertical-align: middleas the rest of the form componentsdisplay: -webkit-box;=> changed todisplay: -webkit-inline-box;to behave properlybefore
after