Skip to content

Conversation

@ilhan007
Copy link
Contributor

@ilhan007 ilhan007 commented Jan 7, 2026

Recently named field has been added for the default slot resulting in double appearance in the docs

Screenshot 2026-01-07 at 15 00 36

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Jan 7, 2026

🧹 Preview deployment cleaned up: https://pr-12859--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 7, 2026 13:07 Inactive
@ilhan007 ilhan007 requested a review from Lukas742 January 7, 2026 13:13
@ilhan007
Copy link
Contributor Author

ilhan007 commented Jan 8, 2026

@hinzzx please talk with @tsanislavgatev if the @slot text filed is needed at all. Because when we looked at it it seems strange, link without a text is not proper usage and I don't think someone will complain about the tabindex for an empty link.

@ilhan007
Copy link
Contributor Author

ilhan007 commented Jan 8, 2026

The issue will be handled via #12870
in another way.
Instead of removing the class jsdoc as in the current PR,
the @slot text will be removed as it turns out it's not needed at all.

@ilhan007 ilhan007 closed this Jan 8, 2026
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 8, 2026 09:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants