feat: BREAKING CHANGE. docker image now requires config file at runtime

henryborchers · henryborchers · commit 373b24c8262e · 2026-02-02T15:52:18.000-06:00
instead of inserting the API key at build time. It now must be mounted during start up time.
diff --git a/vars/runJenkinsPipeline.groovy b/vars/runJenkinsPipeline.groovy
@@ -667,7 +667,7 @@ def call(){
                                                     echo "CONFIG = ${CONFIG}"
                                                     def build_args = CONFIG['docker']['build']['buildArgs'].collect{"--build-arg=${it}"}.join(' ')
                                                     def dockerImage = docker.build("${IMAGE_NAME}:${DOCKER_TAG}", "${build_args} .")
-                                                    withEnv(['DOCKER_REGISTRY=${CONFIG["docker"]["server"]["registry"]}']){
+                                                    withEnv(["DOCKER_REGISTRY=${CONFIG["docker"]["server"]["registry"]}"]){
                                                         sh 'docker login $DOCKER_REGISTRY -u $DOCKER_CRED_USR -p $DOCKER_CRED_PSW'
                                                     }
 //                                                     docker.withRegistry(CONFIG['docker']['server']['registry'], 'jenkins-nexus'){

Original file line number	Diff line number	Diff line change
`@@ -667,7 +667,7 @@ def call(){`
`667`	`667`	`echo "CONFIG = ${CONFIG}"`
`668`	`668`	`def build_args = CONFIG['docker']['build']['buildArgs'].collect{"--build-arg=${it}"}.join(' ')`
`669`	`669`	`def dockerImage = docker.build("${IMAGE_NAME}:${DOCKER_TAG}", "${build_args} .")`
`670`		`- withEnv(['DOCKER_REGISTRY=${CONFIG["docker"]["server"]["registry"]}']){`
	`670`	`+ withEnv(["DOCKER_REGISTRY=${CONFIG["docker"]["server"]["registry"]}"]){`
`671`	`671`	`sh 'docker login $DOCKER_REGISTRY -u $DOCKER_CRED_USR -p $DOCKER_CRED_PSW'`
`672`	`672`	`}`
`673`	`673`	`// docker.withRegistry(CONFIG['docker']['server']['registry'], 'jenkins-nexus'){`