feat: BREAKING CHANGE. docker image now requires config file at runtime

instead of inserting the API key at build time. It now must be mounted during start up time.

Author: henryborchers

Dockerfile

@@ -39,9 +39,7 @@ RUN --mount=type=cache,target=${UV_CACHE_DIR} \
   ./uv/bin/uv sync --group deploy --no-dev --no-editable --no-install-project --find-links=/wheels && \
   ./uv/bin/uv pip install --find-links=/wheels --no-index getmarcapi --no-deps
 EXPOSE 5000
-COPY api.cfg /app/settings.cfg
 ENV GETMARCAPI_SETTINGS=/app/settings.cfg
-RUN  ./.venv/bin/python -m getmarcapi --check
 HEALTHCHECK --interval=30s --timeout=10s --retries=3 CMD curl -f http://localhost:5000 || exit 1
-CMD ./.venv/bin/gunicorn getmarcapi.app:app --bind 0.0.0.0:5000 --log-level=debug
+CMD ./.venv/bin/python -m getmarcapi --check && ./.venv/bin/gunicorn getmarcapi.app:app --bind 0.0.0.0:5000 --log-level=debug
 

vars/runJenkinsPipeline.groovy

@@ -659,15 +659,6 @@ def call(){
                                         }
                                         steps{
                                             script{
-                                                withCredentials([string(credentialsId: 'ALMA_API_KEY', variable: 'API_KEY')]) {
-                                                    writeFile(
-                                                        file: 'api.cfg',
-                                                        text: '''[ALMA_API]
-                                                                 API_DOMAIN=https://api-na.hosted.exlibrisgroup.com
-                                                                 API_KEY=${API_KEY}
-                                                                 '''
-                                                        )
-                                                }
                                                 configFileProvider([configFile(fileId: 'getmarc_deployapi', variable: 'CONFIG_FILE')]) {
                                                     def CONFIG = readJSON(file: CONFIG_FILE)['deploy']
                                                     def build_args = CONFIG['docker']['build']['buildArgs'].collect{"--build-arg=${it}"}.join(' ')