Skip to content

Commit f54cced

Browse files
committed
feat: docker image now requires config file at runtime
BREAKING CHANGE: Instead of inserting the API key at build time. It now must be mounted during start up time.
1 parent 7e59944 commit f54cced

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

vars/runJenkinsPipeline.groovy

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -659,11 +659,13 @@ def call(){
659659
}
660660
steps{
661661
script{
662+
def registryUrl
663+
milestone 2
662664
configFileProvider([configFile(fileId: 'getmarc_deployapi', variable: 'CONFIG_FILE')]) {
663665
try{
664666
def CONFIG = readJSON(file: CONFIG_FILE)['deploy']
665667
def build_args = CONFIG['docker']['build']['buildArgs'].collect{"--build-arg=${it}"}.join(' ')
666-
def registryUrl = CONFIG['docker']['server']['registry']
668+
registryUrl = CONFIG['docker']['server']['registry']
667669
def remoteRegistryImageName = "${registryUrl.replace('http://', '').replace('https://', '')}/${IMAGE_NAME}:${DOCKER_TAG}"
668670
def localImageName = "${IMAGE_NAME}:${DOCKER_TAG}"
669671

0 commit comments

Comments
 (0)