Merge pull request #151 from UIUCLibrary/i146

alexdryden · web-flow · commit ef5d6f6c74db · 2024-04-10T13:12:45.000-04:00
Fixes #146 by waiting to flush till after validataion
diff --git a/Module.php b/Module.php
@@ -1758,7 +1758,7 @@ public function resourceTemplateCreate(Event $event)
                     $team = $teams->findOneBy(['id' => $team_id]);
                     $trt = new TeamResourceTemplate($team, $resource_template);
                     $em->persist($trt);
-                    $em->flush();
+                    //note: don't flush here or the validation is bypassed, which can cause duplicate name icv, see #146
                 }
             } else { # for imports where there is no event triggered, use the users current team
                 $team = $em->getRepository('Teams\Entity\Team')->findOneBy(['id' => $this->currentTeam()]);

Original file line number	Diff line number	Diff line change
`@@ -1758,7 +1758,7 @@ public function resourceTemplateCreate(Event $event)`
`1758`	`1758`	`$team = $teams->findOneBy(['id' => $team_id]);`
`1759`	`1759`	`$trt = new TeamResourceTemplate($team, $resource_template);`
`1760`	`1760`	`$em->persist($trt);`
`1761`		`- $em->flush();`
	`1761`	`+ //note: don't flush here or the validation is bypassed, which can cause duplicate name icv, see #146`
`1762`	`1762`	`}`
`1763`	`1763`	`} else { # for imports where there is no event triggered, use the users current team`
`1764`	`1764`	`$team = $em->getRepository('Teams\Entity\Team')->findOneBy(['id' => $this->currentTeam()]);`