-
Notifications
You must be signed in to change notification settings - Fork 16
Typing/Documentation of cumDeaths28DaysByDeathDate #41
Copy link
Copy link
Open
Description
The metric 'cumDeaths28DaysByDeathDate' reads like it is a monotonically increasing value. However, the last value can be NaN, which arguably ought not to be possible.
If it is intended to return NaNs in the dataset, then the documentation ought, I think, to point this out as pandas has some default handling of NaNs, which will create confusion (typically they are treated as 0 in some aggregations, thus making the data element non-monotonic).
Otherwise, if 'cumDeaths28DaysByDeathDate' is a calculated value (it is the sum of 'newDeaths28DaysByDeathDate'), then the returned value ought to be the same as the previous day's value, rather than NaN.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels