Skip to content

Typing/Documentation of cumDeaths28DaysByDeathDate #41

@timcoote

Description

@timcoote

The metric 'cumDeaths28DaysByDeathDate' reads like it is a monotonically increasing value. However, the last value can be NaN, which arguably ought not to be possible.

If it is intended to return NaNs in the dataset, then the documentation ought, I think, to point this out as pandas has some default handling of NaNs, which will create confusion (typically they are treated as 0 in some aggregations, thus making the data element non-monotonic).

Otherwise, if 'cumDeaths28DaysByDeathDate' is a calculated value (it is the sum of 'newDeaths28DaysByDeathDate'), then the returned value ought to be the same as the previous day's value, rather than NaN.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions