Remove now redundant is_public vs public validation error

Author: kathryn-dale

ingestion/data_transfer_models/headline.py

@@ -10,7 +10,6 @@
 from metrics.api.settings.auth import ALLOW_MISSING_IS_PUBLIC_FIELD, AUTH_ENABLED
 from validation.data_transfer_models.base import (
     IncomingBaseDataModel,
-    NonPublicDataSentToPublicIngestionError,
 )
 
 
@@ -134,14 +133,6 @@ def validate_confidence_intervals(self) -> Self:
         )
         return self
 
-    @model_validator(mode="after")
-    def invalidate_non_public_data_for_public_ingestion(self) -> Self:
-        """Checks that if this is a public instance of the product then `is_public=False` data is invalidated."""
-        if not AUTH_ENABLED and not self.is_public:
-            raise NonPublicDataSentToPublicIngestionError
-
-        return self
-
 
 class HeadlineDTO(IncomingBaseDataModel):
     data: list[InboundHeadlineSpecificFields]

ingestion/data_transfer_models/time_series.py

@@ -9,7 +9,6 @@
 from metrics.api.settings.auth import ALLOW_MISSING_IS_PUBLIC_FIELD, AUTH_ENABLED
 from validation.data_transfer_models.base import (
     IncomingBaseDataModel,
-    NonPublicDataSentToPublicIngestionError,
 )
 
 
@@ -43,14 +42,6 @@ def cast_embargo_to_uk_timezone(
         """
         return validation.cast_date_to_uk_timezone(date_value=embargo)
 
-    @model_validator(mode="after")
-    def invalidate_non_public_data_for_public_ingestion(self) -> Self:
-        """Checks that if this is a public instance of the product then `is_public=False` data is invalidated."""
-        if not AUTH_ENABLED and not self.is_public:
-            raise NonPublicDataSentToPublicIngestionError
-
-        return self
-
 
 class TimeSeriesDTO(IncomingBaseDataModel):
     metric_frequency: str

ingestion/operations/truncated_dataset.py

@@ -20,7 +20,7 @@
 
 
 def _gather_test_data_source_file_paths() -> list[Path]:
-    path_to_test_source_data = f"{ROOT_LEVEL_BASE_DIR}/source_data"
+    path_to_test_source_data = f"{ROOT_LEVEL_BASE_DIR}/kathryn_source_data"
     source_file_names = next(os.walk(path_to_test_source_data))[2]
     return [
         Path(f"{path_to_test_source_data}/{source_file_name}")