Update testing

Author: kathryn-dale

caching/private_api/decorators.py

@@ -53,19 +53,19 @@ def cache_response(
     def decorator(view_function):
         @wraps(view_function)
         def wrapped_view(*args, **kwargs) -> Response:
-            
+
             request = args[1]
             has_jwt = getattr(request, "has_jwt", False)
-            
-            is_public = not(has_jwt)
+
+            is_public = not (has_jwt)
 
             return _retrieve_response_from_cache_or_calculate(
                 view_function,
                 timeout,
                 is_reserved_namespace,
                 is_public,
                 *args,
-                **kwargs
+                **kwargs,
             )
 
         return wrapped_view

cms/snippets/views/global_banner.py

@@ -14,7 +14,7 @@
 
 class GlobalBannerView(APIView):
     permission_classes = []
-    
+
     @classmethod
     @extend_schema(
         tags=["cms"], responses={HTTPStatus.OK: GlobalBannerResponseSerializer}

metrics/api/middleware.py

@@ -2,7 +2,7 @@ class JwtDetectionMiddleware:
     """
     Detects whether a JWT is present in the Authorization header.
     Does NOT decode or validate it — only checks its existence.
-    This will be extended as part of the non-public work. 
+    This will be extended as part of the non-public work.
     """
 
     def __init__(self, get_response):
@@ -13,9 +13,9 @@ def __call__(self, request):
 
         # Expected format (this might change once JWT fully implemented):
         # "Bearer <token>" and token itself is three parts separated by "."
-        
+
         has_jwt = False
-        
+
         if auth_header.startswith("Bearer ") and len(auth_header.split()) == 2:
             token = auth_header.split()[1]
             parts = token.split(".")
@@ -26,4 +26,4 @@ def __call__(self, request):
         # Store on the request for downstream use
         request.has_jwt = has_jwt
 
-        return self.get_response(request)
+        return self.get_response(request)

tests/unit/caching/private_api/test_decorators.py

@@ -242,6 +242,7 @@ def test_item_returned_from_cache_when_is_public_is_set_to_true(
             == mocked_cache_management.retrieve_item_from_cache.return_value
         )
 
+
 class TestCalculateResponseAndSaveInCache:
     @mock.patch(f"{MODULE_PATH}._calculate_response_from_view")
     def test_delegates_call_to_calculate_response_from_view(
@@ -319,10 +320,11 @@ def test_delegates_call_to_save_item_in_cache(
             item=expected_calculated_response,
             timeout=123,
         )
-        
-    
+
     @mock.patch(f"{MODULE_PATH}._calculate_response_from_view")
-    def test_returns_early_when_timeout_zero(self, spy_calculate_response_from_view: mock.MagicMock):
+    def test_returns_early_when_timeout_zero(
+        self, spy_calculate_response_from_view: mock.MagicMock
+    ):
         """
         Given timeout == 0
         When `_calculate_response_and_save_in_cache()` is called
@@ -337,11 +339,10 @@ def test_returns_early_when_timeout_zero(self, spy_calculate_response_from_view:
             mocked_view_function,
             0,  # timeout - set to 0 so triggers early return
             spy_cache_management,
-            "abc", # cache entry key
+            "abc",  # cache entry key
             mock.Mock(),
         )
 
         # Then
         spy_cache_management.save_item_in_cache.assert_not_called()
         assert response == spy_calculate_response_from_view.return_value
-

tests/unit/metrics/api/test_middleware.py

@@ -45,7 +45,7 @@ def test_returns_false_when_no_jwt_provided(self):
         # Then
         self.assertEqual(response.status_code, 200)
         self.assertFalse(request.has_jwt)
-        
+
     def test_only_accepts_valid_prefix_for_jwt(self):
         """
         Given a mocked request with an invalid JWT prefix
@@ -61,7 +61,7 @@ def test_only_accepts_valid_prefix_for_jwt(self):
         # Then
         self.assertEqual(response.status_code, 200)
         self.assertFalse(request.has_jwt)
-        
+
     def test_only_accepts_valid_format_for_jwt(self):
         """
         Given a mocked request with an invalid JWT token format