Update linting errors

Author: kathryn-dale

caching/private_api/decorators.py

@@ -74,9 +74,8 @@ def wrapped_view(*args, **kwargs) -> Response:
 
 def _check_if_valid_non_public_request(request):
     auth = backend.JSONWebTokenAuthentication()
-    is_authenticated = auth.authenticate(request)
 
-    return is_authenticated
+    return auth.authenticate(request)
 
 
 def _retrieve_response_from_cache_or_calculate(
@@ -110,12 +109,12 @@ def _retrieve_response_from_cache_or_calculate(
     request: Request = args[1]
     if not is_public:
         return _calculate_response_from_view(
-            view_function, is_public=is_public, *args, **kwargs
+            view_function, *args, is_public=is_public, **kwargs
         )
 
     if is_caching_v2_enabled() and not is_reserved_namespace:
         return _calculate_response_from_view(
-            view_function, is_public=is_public, *args, **kwargs
+            view_function, *args, is_public=is_public, **kwargs
         )
 
     cache_management = kwargs.pop(
@@ -146,7 +145,7 @@ def _calculate_response_and_save_in_cache(
     view_function, timeout, cache_management, cache_entry_key, *args, **kwargs
 ) -> Response:
     response: Response = _calculate_response_from_view(
-        view_function, is_public=True, *args, **kwargs
+        view_function, *args, is_public=True, **kwargs
     )
     if timeout == 0:
         return response

metrics/data/managers/core_models/time_series.py

@@ -13,7 +13,9 @@
 from django.db.models.query_utils import Q
 from django.utils import timezone
 
-from metrics.api.permissions.fluent_permissions import validate_permissions_for_non_public
+from metrics.api.permissions.fluent_permissions import (
+    validate_permissions_for_non_public,
+)
 from metrics.data.models import RBACPermission
 
 ALLOWABLE_METRIC_VALUE_RANGE_TYPE = tuple[str | float | int, str | float | int]

tests/unit/public_api/v2/views/test_base.py

@@ -3,6 +3,7 @@
 
 from public_api.version_02.views.base import BaseNestedAPITimeSeriesViewV2
 
+
 class TestNestedTimeSeriesView(BaseNestedAPITimeSeriesViewV2):
     """
     Minimal concrete implementation so BaseNestedAPITimeSeriesView can be instantiated
@@ -13,6 +14,7 @@ class TestNestedTimeSeriesView(BaseNestedAPITimeSeriesViewV2):
 
     serializer_class = mock.MagicMock
 
+
 class TestBaseNestedAPITimeSeriesViewV2:
     def test_raises_error_for_lookup_field_property(self):
         """
@@ -42,20 +44,23 @@ def test_raises_error_for_serializer_class_property(self):
         with pytest.raises(NotImplementedError):
             base_view.serializer_class
 
+
 class TestGetAddsPrivateHeaderForNonPublicRequests:
     """
     Tests for the newly added private Cache-Control header behaviour in the `get()` method.
     """
 
-    @mock.patch("public_api.version_02.views.base.backend.JSONWebTokenAuthentication.authenticate")
+    @mock.patch(
+        "public_api.version_02.views.base.backend.JSONWebTokenAuthentication.authenticate"
+    )
     @mock.patch("public_api.version_02.views.base.Response")
     @mock.patch("public_api.version_02.views.base.APITimeSeriesRequestSerializerv2")
     def test_private_header_added_when_valid_jwt(
         self,
         mock_request_serializer_class: mock.MagicMock,
         mock_response_class: mock.MagicMock,
-        mock_backend_auth_authenticate: mock.MagicMock
-        ):
+        mock_backend_auth_authenticate: mock.MagicMock,
+    ):
         """
         Given `backend.JSONWebTokenAuthentication.authenticate()` returns True
         When `get()` is called
@@ -90,7 +95,9 @@ def test_private_header_added_when_valid_jwt(
         )
         assert response == mocked_response
 
-    @mock.patch("public_api.version_02.views.base.backend.JSONWebTokenAuthentication.authenticate")
+    @mock.patch(
+        "public_api.version_02.views.base.backend.JSONWebTokenAuthentication.authenticate"
+    )
     @mock.patch("public_api.version_02.views.base.Response")
     @mock.patch("public_api.version_02.views.base.APITimeSeriesRequestSerializerv2")
     def test_private_header_not_added_when_is_valid_non_public_request_is_false(
@@ -132,4 +139,4 @@ def test_private_header_not_added_when_is_valid_non_public_request_is_false(
         # Then
         mock_backend_auth_authenticate.assert_called_once_with(mocked_request)
         mocked_response.__setitem__.assert_not_called()
-        assert response == mocked_response
+        assert response == mocked_response

tests/unit/public_api/views/test_base.py

@@ -57,8 +57,8 @@ def test_private_header_added_when_valid_jwt(
         self,
         mock_request_serializer_class: mock.MagicMock,
         mock_response_class: mock.MagicMock,
-        mock_backend_auth_authenticate: mock.MagicMock
-        ):
+        mock_backend_auth_authenticate: mock.MagicMock,
+    ):
         """
         Given `backend.JSONWebTokenAuthentication.authenticate()` returns True
         When `get()` is called