SOLWEIG: using landcover class outside of range 1-7

[stefanfluck]

Hi, thanks for your work on this project.

I would like to use the land cover class "Cobble_stone_2014a" which is included in the landcoverclasses_2016a.txt, which has code 0. In the future i'd like to add custom land cover classes.

In file SOLWEIG/solweig.py lines 968-971 it is checked wheter lcgrid is between 1 and 7, and the return statement in 971 exits the calculation. Would it make sense to remove the return statement? This way the user is warned, but calculation continues. Elegant would be to check the minimum and maximum code in the landcoverclasses file and check based on this.

Thanks!

[stefanfluck]

I just tested it and it works fine with commenting out the return statement. It promts the user to check for values out of range, but aknowledging the warning still continues the calculation.

Change in particular, in SOLWEIG/solweig.py:

before:

            if self.landcover == 1.:
                if np.max(self.lcgrid) > 7 or np.min(self.lcgrid) < 1:
                    QMessageBox.warning(self.dlg, "Attention!", "The land cover grid includes integer values higher (or lower) than UMEP-formatted" 
                        " land cover grid (should be integer between 1 and 7). If other LC-classes should be included they also need to be included in landcoverclasses_2016a.txt")
                    return
                    # QMessageBox.critical(self.dlg, "Error", "The land cover grid includes values not appropriate for UMEP-formatted land cover grid (should be integer between 1 and 7).")
                    # return

after:

            if self.landcover == 1.:
                if np.max(self.lcgrid) > 7 or np.min(self.lcgrid) < 1:
                    QMessageBox.warning(self.dlg, "Attention!", "The land cover grid includes integer values higher (or lower) than UMEP-formatted" 
                        " land cover grid (should be integer between 1 and 7). If other LC-classes should be included they also need to be included in landcoverclasses_2016a.txt")
                    # return # MODIFICATION HERE
                    # QMessageBox.critical(self.dlg, "Error", "The land cover grid includes values not appropriate for UMEP-formatted land cover grid (should be integer between 1 and 7).")
                    # return

[biglimp]

Thank you for this suggestion. We will look into this. Heads up, a new version is soon out where also wall materials will be incorporated here.

[stefanfluck]

Oh very cool! looking forward to the new version then!
I am using solweig for various studies for the city of Zurich. I'd be happy to try and test and give feedback to new features as well.