See how well we are following Docker best practices

[kklamberty]

In a previous commit, I followed a suggestion from DeepSource about how to use CMD in a Dockerfile, but in that process the way I approached that fix made deployment not work anymore.

Old commit: a0d16c1
Pull request here in this repo to to fix the problem I introduced in the other repo: #12
The two approaches to using CMD are compared here (including a flow chart that may be helpful for deciding whether we should use shell or exec format for various calls to CMD or entrypoint): https://www.docker.com/blog/docker-best-practices-choosing-between-run-cmd-and-entrypoint/
Docker documentation about CMD: https://docs.docker.com/reference/dockerfile/#cmd
Docker best practices: https://docs.docker.com/build/building/best-practices/

I'm thinking it may be worth trying: CMD ["/wait && server/bin/server"] even though we are not using parameters in case using the exec style has benefits over the shell style, but I want to give that a try and learn a little more before committing to that change.